Skip to content

[frontend][backend] List custom views in settings (#13389)#15390

Merged
fellowseb merged 9 commits intoissue/13389-custom-viewsfrom
issue/13389-3-list-custom-views
Apr 9, 2026
Merged

[frontend][backend] List custom views in settings (#13389)#15390
fellowseb merged 9 commits intoissue/13389-custom-viewsfrom
issue/13389-3-list-custom-views

Conversation

@fellowseb
Copy link
Copy Markdown
Member

@fellowseb fellowseb commented Apr 7, 2026

Proposed changes

Implements chunk Settings: an administrator is able to see listed custom views for an entity type of the "Custom views" feature

A custom view is a dashboard an administrator creates for a given entity type. This dashboard is then viewable (not editable) by "normal" users.

User journeys

  • Case 1: for Entity Types that are eligible to having Custom Views, given there are custom views in the database, when an admin goes to Settings > Customization > [Entity type] a "Custom views" section is displayed and lists the views already created.
  • Case 2: for Entity Types that are eligible to having Custom Views, given there are no custom views in the database, when an admin goes to Settings > Customization > [Entity type] a "Custom views" section is displayed and displays "No items available".
  • Case 3: for Entity Types that are NOT eligible to having Custom Views, when an admin goes to Settings > Customization > [Entity type] no "Custom views" section is displayed.
  • Case 4: non admins don't have access to the Customization page
Enregistrement.de.l.ecran.2026-04-07.a.10.46.11.mov

Specs

Figma: https://www.figma.com/design/K2TFfOTI4MBgWzIyGT2AHV/Custom-views?node-id=119-150&t=y1ubGmkFiRj9H8fl-0
Notion: https://www.notion.so/filigran/Custom-view-Settings-an-administrator-is-able-to-see-listed-custom-views-for-an-entity-type-3188fce17f2a8052b31bcb9b0628e56d?source=copy_link

Details

Frontend
  • Introduces new CustomViewSettings and CustomViewSettingsDataTable components
  • Introduces new useDataTableLocalSort hook to perform client-side sort
  • Integrate to new setting panels
Backend

Data model changes:

  • Adds a customViews query
  • Adds integration test cases, 100% coverage

Related issues

Manual testing

Feature branch deployment available here : https://feat-issue-13389-3-l.octi.staging.filigran.io/.
Use "feat-issue-13389-3-l" credentials in 1Password.

Connect as admin@filigran.io.

Test Intrusion-Set and Campaign entity types for content.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@fellowseb fellowseb changed the base branch from master to issue/13389-custom-views April 7, 2026 07:27
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Apr 7, 2026
@fellowseb fellowseb changed the base branch from issue/13389-custom-views to issue/13389-2-custom-views-tab April 7, 2026 07:28
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 50.92593% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.40%. Comparing base (5b38e17) to head (01a6249).
⚠️ Report is 1 commits behind head on issue/13389-custom-views.

Files with missing lines Patch % Lines
...ypes/custom_views/CustomViewsSettingsDataTable.tsx 0.00% 9 Missing ⚠️
...t/src/components/dataGrid/useDataTableLocalSort.ts 61.90% 8 Missing ⚠️
...src/private/components/settings/sub_types/Root.tsx 0.00% 8 Missing ⚠️
...vate/components/settings/sub_types/SubTypeMenu.tsx 0.00% 8 Missing ⚠️
...ponents/settings/sub_types/SubTypeOutletContext.ts 0.00% 8 Missing ⚠️
...ngs/sub_types/custom_views/CustomViewsSettings.tsx 0.00% 6 Missing ⚠️
.../private/components/settings/sub_types/SubType.tsx 0.00% 4 Missing ⚠️
...c/components/dataGrid/DataTableWithoutFragment.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           issue/13389-custom-views   #15390      +/-   ##
============================================================
+ Coverage                     33.39%   33.40%   +0.01%     
============================================================
  Files                          3172     3175       +3     
  Lines                        214524   214606      +82     
  Branches                      39239    39248       +9     
============================================================
+ Hits                          71631    71687      +56     
- Misses                       142893   142919      +26     
Flag Coverage Δ
opencti-client-python 45.59% <ø> (ø)
opencti-front 3.06% <20.89%> (+0.01%) ⬆️
opencti-graphql 69.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fellowseb fellowseb force-pushed the issue/13389-3-list-custom-views branch from 3afc02e to 3bd1a13 Compare April 7, 2026 07:44
@fellowseb fellowseb marked this pull request as ready for review April 7, 2026 10:01
@fellowseb fellowseb force-pushed the issue/13389-2-custom-views-tab branch 3 times, most recently from 5dd9849 to 4f57061 Compare April 8, 2026 15:22
Base automatically changed from issue/13389-2-custom-views-tab to issue/13389-custom-views April 8, 2026 17:19
@fellowseb fellowseb force-pushed the issue/13389-custom-views branch from 6653e55 to 5b38e17 Compare April 8, 2026 18:15
@fellowseb fellowseb force-pushed the issue/13389-3-list-custom-views branch 4 times, most recently from 338e736 to 25ba4bf Compare April 9, 2026 01:16
@fellowseb fellowseb force-pushed the issue/13389-3-list-custom-views branch from e4ef50c to 1ce369a Compare April 9, 2026 07:09
Comment thread opencti-platform/opencti-front/src/components/dataGrid/useDataTableLocalSort.ts Outdated
Comment thread opencti-platform/opencti-front/src/private/components/settings/sub_types/Root.tsx Outdated
Comment thread opencti-platform/opencti-front/src/private/components/settings/sub_types/Root.tsx Outdated
@fellowseb fellowseb force-pushed the issue/13389-3-list-custom-views branch from 33d6b77 to 01a6249 Compare April 9, 2026 08:44
@fellowseb fellowseb merged commit dd3dcc6 into issue/13389-custom-views Apr 9, 2026
38 checks passed
@fellowseb fellowseb deleted the issue/13389-3-list-custom-views branch April 9, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants