Skip to content

[backend] remove LRU session cache in redis session store (#13855) - #15362

Merged
Xavier Fournet (xfournet) merged 1 commit into
masterfrom
issue/13855
May 5, 2026
Merged

[backend] remove LRU session cache in redis session store (#13855)#15362
Xavier Fournet (xfournet) merged 1 commit into
masterfrom
issue/13855

Conversation

@JeremyCloarec

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

  • remove LRU session cache in redis session store to prevent in memory session temporary desync

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) added the move-to-draft Do not merge this PR until this tag will be removed = move PR to draft. label Apr 3, 2026
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Apr 3, 2026
@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) marked this pull request as ready for review April 3, 2026 08:30
@codecov

codecov Bot commented Apr 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.12%. Comparing base (b7ced05) to head (9db3094).
⚠️ Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
...opencti-graphql/src/database/sessionStore-redis.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15362   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files        3155     3155           
  Lines      214056   214047    -9     
  Branches    39111    39111           
=======================================
- Hits        70904    70903    -1     
+ Misses     143152   143144    -8     
Flag Coverage Δ
opencti-client-python 45.59% <ø> (ø)
opencti-front 2.87% <ø> (ø)
opencti-graphql 69.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return getSession(key).then((data) => {
const sessionFetcher = async (done) => {
try {
let data = await getSession(key);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const ?

@xfournet

Copy link
Copy Markdown
Member

Sébastien Wauquier (@fellowseb) this code seems to be executed at least during end to end tests, but backend is not recording coverage for theses tests. would be possible to add coverage recording in that case ?

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) removed the move-to-draft Do not merge this PR until this tag will be removed = move PR to draft. label Apr 28, 2026
@xfournet
Xavier Fournet (xfournet) merged commit f759204 into master May 5, 2026
47 of 49 checks passed
@xfournet
Xavier Fournet (xfournet) deleted the issue/13855 branch May 5, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"otpValidated" user status is not persisted across opencti-graphql instances

2 participants