[backend/frontend] feat(settings): introduce tenant-scoped settings (#4864) - #5361
Conversation
0bb47f3 to
cf2bb92
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #5361 +/- ##
=====================================================
- Coverage 63.53% 63.50% -0.04%
- Complexity 5640 5642 +2
=====================================================
Files 1109 1115 +6
Lines 33279 33306 +27
Branches 2542 2547 +5
=====================================================
+ Hits 21144 21150 +6
- Misses 10919 10940 +21
Partials 1216 1216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Romuald Lemesle (@RomuDeuxfois) I'm trying to test your PR but i might be missing some context/understanding. Small bug: {t('OpenAEV platform')} is missing in 3/ Question:
|
d52b3f4 to
333f27d
Compare
|
corinnekrych (@corinnekrych) PR ready for a secound round |
| import * as schema from '../Schema'; | ||
| import {TenantSettingsUpdateInput} from "../../utils/api-types"; | ||
|
|
||
| const tenantSettingsUri = () => `/api/tenants/${getCurrentTenantId()}/settings`; |
There was a problem hiding this comment.
So here we have a special case where /api/settings could be used for either tenant-scope or platform-scope therefore
openaev/openaev-front/src/utils/tenant-url-helper.ts
Lines 124 to 134 in 418fa1e
Suggestion: I wonder if a separate name
api/tenant-settings would be cleaner, since we're also adding anew spring REST endpoint
|
Romuald Lemesle (@RomuDeuxfois) here is the test i did: is it expected? |
52583f6 to
975977a
Compare
7c72c6e to
acd5afe
Compare
|
corinnekrych (@corinnekrych) ready for the second round |
babbb53
into
release/current


Proposed changes