Skip to content

[backend/frontend] feat(settings): introduce tenant-scoped settings (#4864) - #5361

Merged
Romuald Lemesle (RomuDeuxfois) merged 5 commits into
release/currentfrom
issue/4864-settings
Apr 14, 2026
Merged

[backend/frontend] feat(settings): introduce tenant-scoped settings (#4864)#5361
Romuald Lemesle (RomuDeuxfois) merged 5 commits into
release/currentfrom
issue/4864-settings

Conversation

@RomuDeuxfois

@RomuDeuxfois Romuald Lemesle (RomuDeuxfois) commented Apr 3, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Move global settings under platform settings
  • Let dashboard settings onto dedicated tenant settings

@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Apr 3, 2026
@RomuDeuxfois
Romuald Lemesle (RomuDeuxfois) force-pushed the issue/4864-settings branch 4 times, most recently from 0bb47f3 to cf2bb92 Compare April 8, 2026 09:26
@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.82353% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.50%. Comparing base (fc1a1ae) to head (4355610).
⚠️ Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...penaev/service/settings/TenantSettingsService.java 0.00% 29 Missing ⚠️
...custom_dashboard/CustomDashboardTenantService.java 0.00% 22 Missing ⚠️
...va/io/openaev/rest/settings/TenantSettingsApi.java 0.00% 9 Missing ⚠️
.../rest/settings/form/TenantSettingsUpdateInput.java 0.00% 1 Missing ⚠️
...v/rest/settings/response/TenantSettingsOutput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #5361      +/-   ##
=====================================================
- Coverage              63.53%   63.50%   -0.04%     
- Complexity              5640     5642       +2     
=====================================================
  Files                   1109     1115       +6     
  Lines                  33279    33306      +27     
  Branches                2542     2547       +5     
=====================================================
+ Hits                   21144    21150       +6     
- Misses                 10919    10940      +21     
  Partials                1216     1216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RomuDeuxfois
Romuald Lemesle (RomuDeuxfois) marked this pull request as ready for review April 8, 2026 09:49
@corinnekrych

Copy link
Copy Markdown
Contributor

Romuald Lemesle (@RomuDeuxfois) I'm trying to test your PR but i might be missing some context/understanding.
1/ I log in as platofm admin
2/ create a tenant A
3/ go to Platform | Parameters see:
Screenshot 2026-04-09 at 14 25 25
4/ go to Settings | Parameters
Screenshot 2026-04-09 at 14 26 19

Small bug: {t('OpenAEV platform')} is missing in 3/

Question:
1/ how do i get dashboard setting displayed?
2/ is the left menu

  • Settings menu => for tenant user: we could have a read only view of platform settings
  • Platform menu => platform user

@RomuDeuxfois
Romuald Lemesle (RomuDeuxfois) force-pushed the issue/4864-settings branch 2 times, most recently from d52b3f4 to 333f27d Compare April 10, 2026 00:39
@RomuDeuxfois

Copy link
Copy Markdown
Member Author

corinnekrych (@corinnekrych) PR ready for a secound round

import * as schema from '../Schema';
import {TenantSettingsUpdateInput} from "../../utils/api-types";

const tenantSettingsUri = () => `/api/tenants/${getCurrentTenantId()}/settings`;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we have a special case where /api/settings could be used for either tenant-scope or platform-scope therefore

const TENANT_EXEMPT_PREFIXES = [
'/api/me',
'/api/login',
'/api/auth',
'/api/reset',
'/api/settings',
'/api/tenants',
'/api/logs',
'/api/images',
'/api/platform-groups',
'/api/platform-roles',
won't work...
Suggestion: I wonder if a separate name api/tenant-settings would be cleaner, since we're also adding anew spring REST endpoint

@corinnekrych

Copy link
Copy Markdown
Contributor

Romuald Lemesle (@RomuDeuxfois) here is the test i did:
1/ create tenant A
2/ create a new dashboard "TOTO"
3/ go to Settings | Parameter, set home dashboard to TOTO
4/ go to Home => blank screen with "select dashboard"
Looking at network tab api/settings/home-dashboard does not return any response

is it expected?

@RomuDeuxfois

Copy link
Copy Markdown
Member Author

corinnekrych (@corinnekrych) ready for the second round

@RomuDeuxfois
Romuald Lemesle (RomuDeuxfois) merged commit babbb53 into release/current Apr 14, 2026
14 checks passed
@RomuDeuxfois
Romuald Lemesle (RomuDeuxfois) deleted the issue/4864-settings branch April 14, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants