Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Modernize tests by migrating from unittest to pytest for clearer assertions and better fixtures, and update packaging to poetry-core.
- Replace unittest.TestCase classes and assertions with plain pytest-style tests and assertions
- Update exception assertions to pytest.raises and remove unittest-only helpers
- Update pyproject.toml to use poetry-core and add pytest dependency
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_pytmfunc.py | Convert unittest assertions and subTest blocks to pytest style; minor refactors in test bodies. |
| tests/test_private_func.py | Convert unittest assertions to pytest style; adjust exception assertions; minor cleanup. |
| pyproject.toml | Switch build backend to poetry-core; reorder Python constraints; add pytest to dependencies. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Not a part of the proposed changes, just a typo in the original tests Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add unit tests for sqldump
Collaborator
|
Tests are failing on missing poetry. |
This was referenced Oct 8, 2025
Collaborator
|
Hi @NoodlesNZ - looks like tests are still failing. |
Contributor
Author
|
@izar sorry for the delay, try this (I don't have permission to run the workflow directly). |
izar
approved these changes
Nov 19, 2025
Collaborator
izar
left a comment
There was a problem hiding this comment.
Looks good to me, and all checks are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the testing framework replacing the unittest framework with pytest. pytest provides clearer assertions, powerful fixtures, and an extensive plugin ecosystem, which will make tests easier to write, maintain, and extend going forward.