Skip to content

[18.0][IMP] subscription_oca: propagate salesman from sale order to subscri…#1399

Open
cvinh wants to merge 1 commit intoOCA:18.0from
invitu:18.0-imp_keep_saleman
Open

[18.0][IMP] subscription_oca: propagate salesman from sale order to subscri…#1399
cvinh wants to merge 1 commit intoOCA:18.0from
invitu:18.0-imp_keep_saleman

Conversation

@cvinh
Copy link
Copy Markdown

@cvinh cvinh commented Mar 6, 2026

…ption
Before this commit, the salesman of the subscription is the user who validates the sale order. If the sale order is confirmed by the customer, it's Administrator instead of the sale order salesman

@cvinh cvinh force-pushed the 18.0-imp_keep_saleman branch 2 times, most recently from 646b719 to 41fdc32 Compare March 6, 2026 22:01
Copy link
Copy Markdown
Contributor

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM!

Comment thread subscription_oca/models/sale_order.py Outdated
@cvinh cvinh force-pushed the 18.0-imp_keep_saleman branch from 41fdc32 to e755f46 Compare April 21, 2026 18:38
@cvinh
Copy link
Copy Markdown
Author

cvinh commented Apr 21, 2026

I don't understand why tests fail
2026-04-21 18:42:58,359 332 WARNING odoo odoo.addons.contract.tests.test_portal.TestContractPortal.test_tour: Killing chrome descendants-or-self of 341: 5 remaining

@luisDIXMIT
Copy link
Copy Markdown
Contributor

Hi @cvinh , this issue was addressed in this PR. I hope it helps you. OCA/web#3507 OCA/oca-addons-repo-template#344

Copy link
Copy Markdown
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants