Draft
Conversation
Nigusu-Allehu
changed the title
Nigusu-Allehu
changed the title
nkolev92
reviewed
Apr 8, 2026
| public async Task InstallPackageToNetCoreProjectFromUI_VerifiesRestore() | ||
| { | ||
| // Arrange | ||
| using (var testContext = new ApexTestContext(VisualStudio, ProjectTemplate.NetStandardClassLib, Logger, addNetStandardFeeds: true)) |
Member
There was a problem hiding this comment.
This adds nuget.org, so not ideal.
Maybe we try to add tests that do not depend on nuget.org
Member
Author
There was a problem hiding this comment.
Thanks, I didn't know we did that. Not sure why we are doing this within the tests. I would have expected the testing VS to have these files already. Removed it to see what happens
There is similar tests i found in
They also use nuget.org to download net standard files.
nkolev92
reviewed
Apr 8, 2026
| [TestMethod] | ||
| [Timeout(DefaultTimeout)] | ||
| [TestCategory("Gate")] | ||
| public async Task InstallPackageToNetCoreProjectFromUI_VerifiesRestore() |
Member
There was a problem hiding this comment.
there's also probably a matching test for this.
I'd be surprised if there isn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3725
Related: https://github.com/NuGet/Client.Engineering/issues/3543
Description
Previously we added a drop for that will be used by the gate tests: #7247. And the drop has a runsetting that specifies a test catagory "Gate". This PR adds more tests to that catagory.
PR Checklist