fix: Update Polish translations for vulnerability severity terms#7249
Open
pomianowski wants to merge 1 commit intoNuGet:devfrom
Open
fix: Update Polish translations for vulnerability severity terms#7249pomianowski wants to merge 1 commit intoNuGet:devfrom
pomianowski wants to merge 1 commit intoNuGet:devfrom
Conversation
This PR fixes a grammar issue in the Polish NU1903 warning message.
Change makes sense from a Polish grammar perspective. In Warning_PackageWithKnownVulnerability, the {2} placeholder is inserted into the phrase ma znane {2} luki w zabezpieczeniach. The noun luki is plural, so the adjective must also be in the plural form. Because of that, wysokie is correct, while wysoka is not.
Current message:
OSTRZEŻENIE: NU1903: Pakiet „System.IO.Packaging 8.0.0 ma znane wysoka luki w zabezpieczeniach o ważności, GHSA-f32c-w444-8ppv
Updated message:
OSTRZEŻENIE: NU1903: Pakiet „System.IO.Packaging 8.0.0 ma znane wysokie luki w zabezpieczeniach o ważności, GHSA-f32c-w444-8ppv
This change replaces “wysoka” with “wysokie” to make the message grammatically correct in Polish.
Contributor
|
@pomianowski Thanks for creating this issue and contribution, translations are handled in another private repository, I created a ticket to update the translations to your suggestions and that will create another automatic PR with the change. Can you create an issue in https://github.com/NuGet/Home/issues so I can link it to that PR and you get the contribution correctly? Thanks! |
Author
|
Hey @martinrrm, thanks for your response. I created issue here NuGet/Home#14841 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a grammar issue in the Polish NU1903 warning message. Change makes sense from a Polish grammar perspective. In Warning_PackageWithKnownVulnerability, the {2} placeholder is inserted into the phrase ma znane {2} luki w zabezpieczeniach. The noun luki is plural, so the adjective must also be in the plural form. Because of that, wysokie is correct, while wysoka is not.
Current message:
OSTRZEŻENIE: NU1903: Pakiet „System.IO.Packaging 8.0.0 ma znane wysoka luki w zabezpieczeniach o ważności, GHSA-f32c-w444-8ppv
Updated message:
OSTRZEŻENIE: NU1903: Pakiet „System.IO.Packaging 8.0.0 ma znane wysokie luki w zabezpieczeniach o ważności, GHSA-f32c-w444-8ppv
This change replaces “wysoka” with “wysokie” to make the message grammatically correct in Polish.
Bug
Fixes:
Description
PR Checklist