Skip to content

Open.mp compatibility#367

Open
d-3fault wants to merge 10 commits intoNexiusTailer:masterfrom
d-3fault:master
Open

Open.mp compatibility#367
d-3fault wants to merge 10 commits intoNexiusTailer:masterfrom
d-3fault:master

Conversation

@d-3fault
Copy link
Copy Markdown

This PR fixes all the warnings / errors regardless of using open.mp or samp and old or new compiler

Added open.mp compatibility
Changed The definition of OnCheatDetected to support both open.mp and samp
forgot to change the definition of OnCheatDetected in the functions tab
Comment thread src/v1.9.68/nex-ac.inc
Comment thread src/v1.9.68/nex-ac.inc
Comment thread src/v1.9.68/nex-ac.inc
Comment thread src/v1.9.68/nex-ac.inc Outdated
Comment thread src/v1.9.68/nex-ac.inc
Comment thread src/v1.9.68/nex-ac.inc
@d-3fault
Copy link
Copy Markdown
Author

Please check it out now and tell me if i should change something

Comment thread src/v1.9.68/nex-ac.inc Outdated
Comment thread src/v1.9.68/nex-ac.inc Outdated
Comment thread src/v1.9.68/nex-ac.inc
Comment thread src/v1.9.68/nex-ac.inc Outdated
Comment thread CHANGELOG.md
@NexiusTailer
Copy link
Copy Markdown
Owner

NexiusTailer commented Mar 23, 2026

Ok, checking the code now I can notice only a few things:

  1. Looks like you missed acc_AddPlayerClassEx from adding tags if being on omp-stdlib, basically same additions like in acc_AddPlayerClass should be copied there
  2. SPECIAL_ACTION_CARRY still occured in this one place, which should be changed to 25 like it's in all other places
  3. AC_CONST should be moved a bit higher, before #if !defined FILTERSCRIPT check at the top of the .inc file. The reason is that this macro is used for ALS native hooks (those ones with acc_ prefixes) which can be called from a filterscript too, since anticheat redirects all necessary natives to be called from gamemode
  4. This code can be omitted now since we anyway pass needed tag here, to the rest of the hook chain

Please also make sure you have covered all native hooks (maybe there's anything more left other than AddPlayerClassEx). If it's the only one missed function, I don't have anything major to notice besides it.

@d-3fault
Copy link
Copy Markdown
Author

d-3fault commented Mar 23, 2026

i used the script that contains most of the functions you provided in discord (after converting it to open.mp) , it may be missing some functions but the only warning that was shown is the one you mentioned in acc_AddPlayerClassEx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants