Skip to content

Fix: Add maximum length validation for communityName and communityBio (issue #129) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshul23102 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Add maximum length validation for communityName and communityBio (issue #129) #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/Auth/v1/hooks/useSignupForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { z } from "zod";

export const signupSchema = z
.object({
communityName: z.string().min(2, "Community name must be at least 2 characters"),
communityBio: z.string().min(10, "Bio must be at least 10 characters"),
communityName: z.string().min(2, "Community name must be at least 2 characters").max(100, "Community name must not exceed 100 characters"),
communityBio: z.string().min(10, "Bio must be at least 10 characters").max(500, "Bio must not exceed 500 characters"),
Comment on lines +7 to +8

@gemini-code-assist gemini-code-assist Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is recommended to trim whitespace from the input strings before validating their length. Without .trim(), users can bypass the minimum length requirements by entering spaces, or accidentally include leading/trailing spaces that count towards the maximum length limit.

Suggested change
communityName: z.string().min(2, "Community name must be at least 2 characters").max(100, "Community name must not exceed 100 characters"),
communityBio: z.string().min(10, "Bio must be at least 10 characters").max(500, "Bio must not exceed 500 characters"),
communityName: z.string().trim().min(2, "Community name must be at least 2 characters").max(100, "Community name must not exceed 100 characters"),
communityBio: z.string().trim().min(10, "Bio must be at least 10 characters").max(500, "Bio must not exceed 500 characters"),

communityLogo: z.string().optional(),
communityWebsite: z
.string()
Expand Down