eval: fix flaky testProcessor state machine in EvaluatorSuite#1895
Merged
brharrington merged 1 commit intoNetflix:mainfrom Apr 10, 2026
Merged
eval: fix flaky testProcessor state machine in EvaluatorSuite#1895brharrington merged 1 commit intoNetflix:mainfrom
brharrington merged 1 commit intoNetflix:mainfrom
Conversation
Simplify the state machine from 4 states to 3, removing the unreliable check that "one" messages had stopped arriving. With async boundaries and buffering in the pipeline, buffered messages for a removed data source can continue to arrive intermittently, causing the old state 3 to never complete. The simplified version verifies the essential behavior: data source additions and removals propagate correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the state machine from 4 states to 3, removing the unreliable check that "one" messages had stopped arriving. With async boundaries and buffering in the pipeline, buffered messages for a removed data source can continue to arrive intermittently, causing the old state 3 to never complete. The simplified version verifies the essential behavior: data source additions and removals propagate correctly.