feat(helm): add ipmi sim support config to machine-a-tron - #4687
Draft
akorobkov-nvda wants to merge 3 commits into
Draft
feat(helm): add ipmi sim support config to machine-a-tron#4687akorobkov-nvda wants to merge 3 commits into
akorobkov-nvda wants to merge 3 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
akorobkov-nvda
added
helm charts
scaling
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the IPMI sim support for machine-a-tron (MAT) k8s controller mode
Background: Previous PRs (#3542, #3687) added IPMI sim support to MAT and the controller already has the logic to create udp service ports
When enabled, each IPMI BMC gets an independent IPMI sim and the controller automatically creates udp service ports for IPMI access alongside the existing TCP Redfish ports.
Related issues
Closes #4413
Type of Change
Testing
Tests results:
helm unittest helm/charts/nico-machine-a-tron- All 20 tests pass (including 2 new IPMI config tests)go test ./...indev/k8s/machine-a-tron-controller- All tests pass