test(libmlx): add enumerated table-driven cases to raise coverage#2516
Merged
Conversation
This adds table-driven coverage tests across `libmlx` using the `carbide-test-support` framework. The embedded `mlxconfig` parsers, variable value/spec/registry conversions and validators, runner result types, JSON parsing, profile (de)serialization, and lockdown serialization. The idea is to simply, and more comprehensively, enumerate input variants into the existing `check_cases`/`check_values` tables, targeting the code being tested. Coverage (cargo-llvm-cov), before (origin/main) vs after, with function and line converage increasing to ~80%. ``` ┌──────────┬──────────────────────┬───────────────┐ │ Metric │ Before (origin/main) │ After (this) │ ├──────────┼──────────────────────┼───────────────┤ │ Region │ 48.61% │ 73.86% │ ├──────────┼──────────────────────┼───────────────┤ │ Function │ 58.15% │ 81.93% │ ├──────────┼──────────────────────┼───────────────┤ │ Line │ 50.18% │ 81.12% │ └──────────┴──────────────────────┴───────────────┘ ``` The remaining uncovered surface is mostly IO related, which needs dry-run/mock harnessing rather than additional table rows. All tests pass and clippy is clean. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
poroh
approved these changes
Jun 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds table-driven coverage tests across
libmlxusing thecarbide-test-supportframework, increasing line coverage from 50 -> 80%, and function coverage from 58 -> 81%. The embeddedmlxconfigparsers, variable value/spec/registry conversions and validators, runner result types, JSON parsing, profile (de)serialization, and lockdown serialization.The idea is to simply, and more comprehensively, enumerate input variants into the existing
check_cases/check_valuestables, targeting the code being tested.Coverage (cargo-llvm-cov), before (origin/main) vs after, with function and line converage increasing to ~80%.
The remaining uncovered surface is mostly IO related, which needs dry-run/mock harnessing rather than additional table rows.
All tests pass and clippy is clean.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes