Package OmniDreams WebRTC assets in wheels#328
Conversation
Greptile SummaryThis PR fixes asset-bundling for the OmniDreams WebRTC web UI by addressing a gap identified in the previous review cycle: without an
Confidence Score: 5/5Safe to merge — the two-file change adds a package marker and a package-data glob that together ensure the WebRTC web assets land in the built wheel as intended. Both files are minimal and targeted: the init.py is a marker-only file, and the pyproject.toml line adds a single package-data stanza whose glob patterns exactly cover the three asset files currently in the directory. The fix correctly addresses the root cause identified in the prior review thread. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["uv build integrations/omnidreams"] --> B["setuptools packages.find\ninclude=['omnidreams*']"]
B --> C["Discovers omnidreams.webrtc.web\n(enabled by new __init__.py)"]
C --> D["Applies package-data entry\nomnidreams.webrtc.web = ['*.html','*.css','*.js']"]
D --> E["Bundles assets into wheel\nrequest_session.html\nrequest_session.css\nrequest_session.js"]
E --> F["Installed wheel: WEB_DIR assets present at runtime"]
Reviews (2): Last reviewed commit: "Add OmniDreams WebRTC web package marker" | Re-trigger Greptile |
|
/ok to test 255a4b3 |
|
Thanks a lot @fallintoplace , that is some sloppy programming from me! |
|
/ok to test 08dfbfc |
Summary
Include the OmniDreams WebRTC web UI files in the flashdreams-omnidreams wheel so the server can serve the HTML, CSS, and JS assets after installation.
Fixes #302.
Tests
uv build integrations/omnidreams