Skip to content

Package OmniDreams WebRTC assets in wheels#328

Merged
jmccaffrey-nv merged 2 commits into
NVIDIA:mainfrom
fallintoplace:omnidreams-wheel-webrtc-assets
Jun 12, 2026
Merged

Package OmniDreams WebRTC assets in wheels#328
jmccaffrey-nv merged 2 commits into
NVIDIA:mainfrom
fallintoplace:omnidreams-wheel-webrtc-assets

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

Include the OmniDreams WebRTC web UI files in the flashdreams-omnidreams wheel so the server can serve the HTML, CSS, and JS assets after installation.

Fixes #302.

Tests

  • uv build integrations/omnidreams

@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes asset-bundling for the OmniDreams WebRTC web UI by addressing a gap identified in the previous review cycle: without an __init__.py, setuptools.packages.find would silently skip the web/ directory and the package-data entry would be a no-op.

  • Adds integrations/omnidreams/omnidreams/webrtc/web/__init__.py — minimal package marker matching the style of the existing webrtc/__init__.py, making omnidreams.webrtc.web discoverable by packages.find.
  • Adds "omnidreams.webrtc.web" = ["*.html", "*.css", "*.js"] to [tool.setuptools.package-data] in pyproject.toml, covering all three asset files currently in the directory (request_session.html, request_session.css, request_session.js).

Confidence Score: 5/5

Safe to merge — the two-file change adds a package marker and a package-data glob that together ensure the WebRTC web assets land in the built wheel as intended.

Both files are minimal and targeted: the init.py is a marker-only file, and the pyproject.toml line adds a single package-data stanza whose glob patterns exactly cover the three asset files currently in the directory. The fix correctly addresses the root cause identified in the prior review thread.

No files require special attention.

Important Files Changed

Filename Overview
integrations/omnidreams/omnidreams/webrtc/web/init.py New package marker file enabling setuptools discovery of omnidreams.webrtc.web; uses the same SPDX short-form header as the sibling webrtc/__init__.py.
integrations/omnidreams/pyproject.toml Adds package-data entry for omnidreams.webrtc.web covering all three asset types (.html, .css, .js) present in the directory; glob patterns match all current web assets.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["uv build integrations/omnidreams"] --> B["setuptools packages.find\ninclude=['omnidreams*']"]
    B --> C["Discovers omnidreams.webrtc.web\n(enabled by new __init__.py)"]
    C --> D["Applies package-data entry\nomnidreams.webrtc.web = ['*.html','*.css','*.js']"]
    D --> E["Bundles assets into wheel\nrequest_session.html\nrequest_session.css\nrequest_session.js"]
    E --> F["Installed wheel: WEB_DIR assets present at runtime"]
Loading

Reviews (2): Last reviewed commit: "Add OmniDreams WebRTC web package marker" | Re-trigger Greptile

Comment thread integrations/omnidreams/pyproject.toml
@jmccaffrey-nv

Copy link
Copy Markdown
Collaborator

/ok to test 255a4b3

@jmccaffrey-nv
jmccaffrey-nv self-requested a review June 11, 2026 06:10
@jatentaki

Copy link
Copy Markdown
Collaborator

Thanks a lot @fallintoplace , that is some sloppy programming from me!

@jmccaffrey-nv

Copy link
Copy Markdown
Collaborator

/ok to test 08dfbfc

@jmccaffrey-nv
jmccaffrey-nv enabled auto-merge June 12, 2026 22:31
@jmccaffrey-nv
jmccaffrey-nv added this pull request to the merge queue Jun 12, 2026
Merged via the queue into NVIDIA:main with commit 8373323 Jun 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package OmniDreams WebRTC assets in a wheel build

4 participants