[cuda.compute]: add CI job for minimal cuda-cccl extra#9434
[cuda.compute]: add CI job for minimal cuda-cccl extra#9434NaderAlAwar wants to merge 8 commits into
minimal cuda-cccl extra#9434Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
important: WalkthroughAdds a minimal Python CI job and runner script; applies ChangesPython compute minimal CI and test execution path
Assessment against linked issues
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
ci/test_cuda_compute_minimal_python.sh (1)
22-23: 📐 Maintainability & Code Quality | ⚡ Quick winsuggestion: Line 22 and Line 23 hardcode
/home/coder/cccleven thoughrepo_rootis already available; use${repo_root}for artifact download andwheelhouse_dirto avoid CI workspace-path coupling.As per coding guidelines,
ci/**/*should focus on environment setup and clear failures; removing hardcoded workspace paths improves that reliability.Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7f0b31eb-d63b-4174-870b-b82feb8faae3
📒 Files selected for processing (26)
ci/matrix.yamlci/test_cuda_compute_minimal_python.shpython/cuda_cccl/cuda/compute/algorithms/_binary_search.pypython/cuda_cccl/tests/compute/test_binary_search.pypython/cuda_cccl/tests/compute/test_bindings.pypython/cuda_cccl/tests/compute/test_deferred_annotations.pypython/cuda_cccl/tests/compute/test_func_caching.pypython/cuda_cccl/tests/compute/test_histogram.pypython/cuda_cccl/tests/compute/test_iterators.pypython/cuda_cccl/tests/compute/test_merge_sort.pypython/cuda_cccl/tests/compute/test_nested_struct.pypython/cuda_cccl/tests/compute/test_no_numba.pypython/cuda_cccl/tests/compute/test_permutation_iterator.pypython/cuda_cccl/tests/compute/test_radix_sort.pypython/cuda_cccl/tests/compute/test_reduce.pypython/cuda_cccl/tests/compute/test_scan.pypython/cuda_cccl/tests/compute/test_segmented_reduce.pypython/cuda_cccl/tests/compute/test_segmented_sort.pypython/cuda_cccl/tests/compute/test_select.pypython/cuda_cccl/tests/compute/test_shuffle_iterator.pypython/cuda_cccl/tests/compute/test_struct_field_validation.pypython/cuda_cccl/tests/compute/test_three_way_partition.pypython/cuda_cccl/tests/compute/test_transform.pypython/cuda_cccl/tests/compute/test_unique_by_key.pypython/cuda_cccl/tests/compute/test_void_ptr_wrapper_validation.pypython/cuda_cccl/tests/compute/test_zip_iterator.py
|
pre-commit.ci autofix |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6ed5e7f1-eb57-4e74-9b43-32332ab11d65
📒 Files selected for processing (1)
python/cuda_cccl/tests/compute/test_binary_search.py
|
pre-commit.ci autofix |
|
/ok to test c2e7c01 |
|
/ok to test b09c9c6 |
😬 CI Workflow Results🟥 Finished in 2h 29m: Pass: 96%/504 | Total: 4d 09h | Max: 51m 30s | Hits: 95%/667616See results here. |
Description
closes #9433
This also decouples our tests from numba.cuda further since
minimaldoes not install that package. We do this by switching to CuPy and cuda.core where necessary. Also, this ensures that each algorithm has at least one test that can run with theminimalextraChecklist