Add LFS hook cleanup for self-hosted runners#845
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoved Git LFS configuration from the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
📖 Docs preview: https://d3in15bfzp49i0.cloudfront.net/845/index.html |
7881245 to
014d7e3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 42.82% 43.40% +0.57%
==========================================
Files 203 203
Lines 27123 27123
Branches 7759 7759
==========================================
+ Hits 11616 11773 +157
+ Misses 15398 15240 -158
- Partials 109 110 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
014d7e3 to
b755d3f
Compare
b755d3f to
48c6c7c
Compare
48c6c7c to
54ea593
Compare
Removes stale LFS hook files left by previous jobs on shared self-hosted runners, preventing "Hook already exists: pre-push" failures. git lfs uninstall --local only removes filter config, not hook files, so we delete them directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
54ea593 to
31a4c19
Compare
Description
Fixes Git LFS
Hook already existsfailures on self-hosted runners.Root cause: Self-hosted runners share workspace between jobs. When
ci-internalandcoverageboth run on the same runner withlfs: true, the first job installs LFS hooks (pre-push, post-checkout, etc.) that persist in the workspace. The second job'sgit lfs install --local(run byactions/checkout) refuses to overwrite the existing hooks and fails with exit code 2.Fix: Remove stale LFS hooks before checkout in both self-hosted runner jobs (
ci-internalandcoverage). This cleans up any stale hooks from previous runs soactions/checkoutwithlfs: truecan install them cleanly.Issue - None
Checklist