fix(inference): sanitize route display output#7170
Conversation
Sanitize control characters in human-readable output while preserving raw route values for JSON and programmatic callers. Co-authored-by: HwangJohn <angelic805@gmail.com> Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughInference logging now sanitizes provider and model route values for human-readable output while preserving raw values in the resolved result. A unit test covers control and escape character handling. ChangesInference display sanitization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the branch. TypeScript / code-coverage/cliThe overall coverage in the branch remains at 80%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Exact-head maintainer audit on 184172d: the display-only sanitizer is applied after route parsing, while raw provider/model values remain unchanged for JSON and programmatic callers. Focused inference/config coverage passes 60/60, CLI type-check passes, the commit is GitHub Verified with DCO and original-author credit, all CI/advisors/protected E2E are green, and there are no unresolved review threads. No blocking security or correctness issue found. Independent review requested from @cv because the PR is authored by the current maintainer account. |
Summary
Sanitizes control characters in human-readable inference route output while preserving raw provider and model values for JSON output and programmatic callers. This is the upstream replacement for #7165 so required trusted CI and credentialed E2E can execute; the implementation remains credited to original author HwangJohn.
Changes
Type of Change
Quality Gates
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Signed-off-by: Apurv Kumaria akumaria@nvidia.com
Summary by CodeRabbit