Conversation
Greptile SummaryThis PR fixes Mac development setup by adding
|
| Filename | Overview |
|---|---|
| nemo_retriever/pyproject.toml | Adds sys_platform != 'darwin' markers to the torch and torchvision source entries so they are fetched from PyPI (CPU/MPS builds) on macOS instead of the CUDA-only wheel index that has no macOS wheels. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv install on developer machine] --> B{sys_platform?}
B -->|darwin - macOS| C[Resolve torch & torchvision<br/>from PyPI default index]
B -->|linux / win32| D[Resolve torch & torchvision<br/>from torch-cuda index<br/>download.pytorch.org/whl/cu130]
C --> E[CPU / MPS build installed ✓]
D --> F[CUDA-enabled build installed ✓]
D --> G[Resolve vllm from<br/>GitHub release URLs<br/>x86_64 or aarch64]
B -->|darwin - macOS| H[vllm skipped<br/>sys_platform == linux guard<br/>in project.dependencies]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: nemo_retriever/pyproject.toml
Line: 64-67
Comment:
**Consider platform-guarding remaining GPU-only Nemotron packages**
`nemotron-page-elements-v3`, `nemotron-graphic-elements-v1`, and `nemotron-table-structure-v1` are sourced from `test-pypi` without any platform marker, and their source index entry has no macOS guard. If these packages lack macOS wheels on test-pypi, `uv sync` on a Mac will still fail after this fix. `nemotron-ocr` already has `sys_platform == 'linux'` in the dependency spec — it may be worth applying the same treatment to the other three Nemotron packages if they also publish only Linux wheels.
How can I resolve this? If you propose a fix, please make it concise.Reviews (3): Last reviewed commit: "Merge branch 'main' into shkolar/fix-mac" | Re-trigger Greptile
Signed-off-by: Yuval Shkolar <yshkolar@nvidia.com>
d2e9b33 to
00837ef
Compare
Fix Installation of the dependencies when developing on mac