Fix use_triton default in BoostingTreeModelConfig to None (auto-detect) - #16124
Open
shoemoney wants to merge 1 commit into
Open
Fix use_triton default in BoostingTreeModelConfig to None (auto-detect)#16124shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
Signed-off-by: Jeremy Schoemaker <jeremy@shoemoney.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16122
BoostingTreeModelConfig.use_tritondefaulted toTrue(forced mode), while the sibling configsBoostingTreeConfigin the same file andNGramLMConfiginngram_lm_batched.pydefault toNone, meaning auto-detect.from_configforwards the value verbatim, so enabling phrase boosting viakey_phrases_listorkey_phrases_fileon a CUDA machine without triton installed crashes withModuleNotFoundErrorinstead of falling back to the PyTorch kernel.This changes the default to
NonesoNGramGPULanguageModel.__init__resolves it againstTRITON_AVAILABLE(ngram_lm_batched.py:539), matching the documented contract:Nonemeans auto,Trueremains available as forced mode.One-line change; explicit
use_triton=True/Falseoverrides are unaffected.