Add native THD packed ASR encoders - #16053
Open
pzelasko wants to merge 24 commits into
Open
Conversation
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 11, 2026 13:15
3b58f76 to
2cea2c0
Compare
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 11, 2026 18:47
8b96983 to
d49ae3c
Compare
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
marked this pull request as ready for review
August 12, 2026 20:56
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 13, 2026 14:56
bd38380 to
4a4f436
Compare
Collaborator
Author
|
/ok to test 4a4f436 |
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 13, 2026 22:15
e34797a to
d05855d
Compare
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 14, 2026 23:28
6db3edb to
d12bfd3
Compare
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
force-pushed
the
codex/pr-16048
branch
from
August 14, 2026 23:36
d12bfd3 to
45da3fb
Compare
| independently inside :class:`IndependentDualEncoder`; their same-rate states | ||
| are concatenated before the existing perception-to-LLM projection. | ||
| """ | ||
| from nemo.collections.speechlm2.modules.perception import IdentityConnector, IndependentDualEncoder |
This was referenced Aug 16, 2026
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Collaborator
Author
|
/ok to test c0fc91f |
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Collaborator
Author
|
/ok to test 4b242b5 |
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Collaborator
Author
|
/ok to test a86b4a0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grouped_mmtop-k MoE where supportedThis is a dependent PR based on #16048 and targets its head branch,
moe_pee_ggemm_encoder_chunking.Motivation
The existing packed path uses FlexAttention's sparse masks but still materializes padded BHSD activations. Native THD execution avoids that memory cost. PEE additionally needs experts to remain parallel; the production path therefore groups compatible experts per layer, while serial THD remains only as a numerical oracle and compatibility fallback.
Performance
BF16 measurements on an RTX PRO 6000 Blackwell:
The committed benchmark report contains the complete methodology, aggregate measurements, numerical preflight, source hashes, and profiler queries. Raw generated JSON trials remain local to keep the review diff focused.
Compatibility
Validation
rtol=0.03, atol=0.03; relative L2 differences are approximately 0.004-0.005