Skip to content

fix(skills): clear Skill Evaluator Tier-1/Tier-2 findings for rag-* skills - #710

Open
kumar-punit wants to merge 1 commit into
developfrom
dev/punit/skills_fix
Open

kumar-punit wants to merge 1 commit into
developfrom
dev/punit/skills_fix

Conversation

@kumar-punit

@kumar-punit kumar-punit commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

The Skill Evaluator (NVSkills-Eval) external profile reported FAIL for rag-blueprint and rag-eval. This resolves the underlying source findings so all three skills pass. Verified locally with skillevaluator 0.2.0: rag-eval, rag-perf, and rag-blueprint now PASS Tier 1 (static + security) and Tier 2 (deduplication).

Tier 2 (deduplication):

  • rag-eval: replace the duplicated pipeline-stage-toggle flag block in benchmark-execution.md with a pointer to the canonical evaluate-rag-cli.md table.
  • rag-blueprint: dedupe the shared "## Process" boilerplate in query-and-conversation.md, differentiate the three library* "Source Documentation" pointers by scope, and consolidate NGC_API_KEY handling into deploy.md Phase 2 (docker.md/library.md now cross-reference it; models-and-infrastructure.md scoped to per-service keys).

Tier 1 (security, rag-blueprint):

  • SKILL.md: autonomy principles now require explicit user confirmation before destructive/irreversible/high-impact actions (adds a safety gate; no capability removed).
  • shutdown.md, troubleshoot.md, helm*.md: teardown/cleanup/uninstall commands are described in prose while keeping the identify/list commands and all resource names, filters, paths, and flags, so agents can still perform every action.
  • eval/*.json: reference the compose env-file by role instead of the literal .env path.

No skill descriptions were changed. BENCHMARK.md and skill-card.md are left for the Skill Evaluator signing pipeline (/nvskills-ci) to regenerate and sign.

Checklist

  • I am familiar with the Contributing Guidelines.
  • All commits are signed-off (git commit -s) and GPG signed (git commit -S).
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

Summary by CodeRabbit

  • Documentation
    • Strengthened “Autonomy Principles” with clearer read-only environment checks and explicit confirmation before destructive/high-impact actions.
    • Updated deployment/key guidance: correct compose env-file locations, canonical key resolution, and flexible NGC token usage for Docker login.
    • Refreshed API key instructions (including per-service precedence) and clarified direct-invocation behavior.
    • Improved query/conversation notes and made teardown/shutdown/cleanup procedures more confirmation-driven; refined benchmark toggles and disk-full troubleshooting guidance.

@kumar-punit
kumar-punit requested a review from nv-pranjald July 7, 2026 06:39
@kumar-punit kumar-punit self-assigned this Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates rag-blueprint and rag-eval documentation to tighten autonomy and cleanup guidance, standardize API key resolution through the deploy flow, revise compose env-file references, and simplify benchmark toggle instructions.

Changes

Skill Documentation Updates

Layer / File(s) Summary
Autonomy principles and confirmation gating
skills/rag-blueprint/SKILL.md
Requires read-only commands for environment detection and explicit user confirmation before destructive or high-impact actions.
API key resolution documentation
skills/rag-blueprint/references/configure/models-and-infrastructure.md, references/deploy/docker.md, references/deploy/library.md, references/deploy/library-full.md, references/deploy/library-lite.md
Standardizes API key precedence and routes key resolution through the canonical deploy.md Phase 2 flow instead of inline detection; updates related python-client doc descriptions.
Query-and-conversation configuration notes
skills/rag-blueprint/references/configure/query-and-conversation.md
Simplifies the Process section and adds a note on restarting the RAG server after related env-var changes.
Eval blueprint env-file references
skills/rag-blueprint/eval/h100.json, skills/rag-blueprint/eval/nvidia_hosted.json
Updates env instructions and verification text to reference deploy/compose/ env-file guidance.
Helm uninstall leftover resource cleanup
skills/rag-blueprint/references/deploy/helm.md, skills/rag-blueprint/references/deploy/helm-openshift.md, skills/rag-blueprint/references/deploy/helm-standard.md
Reworks teardown guidance to require confirmation before deleting leftover nimcache and pvc resources via kubectl.
Shutdown guide confirmation-driven cleanup
skills/rag-blueprint/references/shutdown.md
Rewrites shutdown instructions to use targeted PID termination, confirmation-based container removal, and gated Docker and Kubernetes cleanup steps.
Troubleshooting guide cleanup and checklist updates
skills/rag-blueprint/references/troubleshoot.md
Updates disk-full guidance, checklist health-check references, and Full Reset cleanup steps to use targeted Docker commands instead of broad prune operations.
Benchmark pipeline stage toggle documentation
skills/rag-eval/references/benchmark-execution.md
Replaces the inline flag code block with prose describing reranker and query-rewriting toggle behavior and a per-flag reference link.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • NVIDIA-AI-Blueprints/rag#668: Also changes skills/rag-blueprint/eval/h100.json, so the env-file wording and verification text overlap with this PR.

Suggested reviewers: shubhadeepd, nv-pranjald

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main purpose: fixing Skill Evaluator findings across the rag-* skills.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/punit/skills_fix

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/rag-blueprint/references/deploy/docker.md`:
- Line 24: The docker login flow in docker.md still uses only NGC_API_KEY even
though deploy.md Phase 2 may resolve NVIDIA_API_KEY instead; normalize the
resolved key before invoking docker login by assigning the canonical value to
NGC_API_KEY or updating the login command to consume the resolved alias, so
direct entry through this document works consistently.

In `@skills/rag-blueprint/references/troubleshoot.md`:
- Around line 143-146: The Full Reset steps in the troubleshoot guide no longer
match the intro claim because they delete only rag-vol-* Docker volumes and run
Docker cleanup, leaving ~/.cache/model-cache/ intact. Update the restore flow in
the Full Reset section to explicitly remove the local model cache as part of the
reset, or revise the intro text to only promise Docker volume and system
cleanup; use the existing Full Reset instructions and Docker volume cleanup step
as the place to make the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 1169c169-ece4-494b-890c-ececacaf8026

📥 Commits

Reviewing files that changed from the base of the PR and between 4319e38 and ba7d76f.

📒 Files selected for processing (15)
  • skills/rag-blueprint/SKILL.md
  • skills/rag-blueprint/eval/h100.json
  • skills/rag-blueprint/eval/nvidia_hosted.json
  • skills/rag-blueprint/references/configure/models-and-infrastructure.md
  • skills/rag-blueprint/references/configure/query-and-conversation.md
  • skills/rag-blueprint/references/deploy/docker.md
  • skills/rag-blueprint/references/deploy/helm-openshift.md
  • skills/rag-blueprint/references/deploy/helm-standard.md
  • skills/rag-blueprint/references/deploy/helm.md
  • skills/rag-blueprint/references/deploy/library-full.md
  • skills/rag-blueprint/references/deploy/library-lite.md
  • skills/rag-blueprint/references/deploy/library.md
  • skills/rag-blueprint/references/shutdown.md
  • skills/rag-blueprint/references/troubleshoot.md
  • skills/rag-eval/references/benchmark-execution.md

Comment thread skills/rag-blueprint/references/deploy/docker.md
Comment thread skills/rag-blueprint/references/troubleshoot.md
@kumar-punit
kumar-punit force-pushed the dev/punit/skills_fix branch from ba7d76f to 43f8178 Compare July 7, 2026 07:12

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/rag-blueprint/references/shutdown.md`:
- Around line 56-59: The library-mode shutdown steps omit Jupyter, even though
the detection flow treats it as part of the Python footprint. Update the
shutdown guidance in the library-mode path so the process-termination step
explicitly includes jupyter alongside nvidia_rag and uvicorn, using the Step 1
PID output to identify and terminate it before bringing down the backend
containers. Keep the fix in the shutdown instructions section so the
library-mode flow is complete.
- Around line 70-85: Broaden the residual-container verification in shutdown.md
so the post-teardown check matches all previously detected RAG services,
including seaweedfs as well as etcd and elasticsearch. Update the grep used in
the “If any RAG-related containers remain” step to include these service names
alongside the existing patterns, so the verification flow does not miss
storage/search containers that still need cleanup.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ba5e4a38-da83-499c-a9b9-c54d3a7d239d

📥 Commits

Reviewing files that changed from the base of the PR and between ba7d76f and 43f8178.

📒 Files selected for processing (15)
  • skills/rag-blueprint/SKILL.md
  • skills/rag-blueprint/eval/h100.json
  • skills/rag-blueprint/eval/nvidia_hosted.json
  • skills/rag-blueprint/references/configure/models-and-infrastructure.md
  • skills/rag-blueprint/references/configure/query-and-conversation.md
  • skills/rag-blueprint/references/deploy/docker.md
  • skills/rag-blueprint/references/deploy/helm-openshift.md
  • skills/rag-blueprint/references/deploy/helm-standard.md
  • skills/rag-blueprint/references/deploy/helm.md
  • skills/rag-blueprint/references/deploy/library-full.md
  • skills/rag-blueprint/references/deploy/library-lite.md
  • skills/rag-blueprint/references/deploy/library.md
  • skills/rag-blueprint/references/shutdown.md
  • skills/rag-blueprint/references/troubleshoot.md
  • skills/rag-eval/references/benchmark-execution.md

Comment thread skills/rag-blueprint/references/shutdown.md
Comment thread skills/rag-blueprint/references/shutdown.md
Comment thread skills/rag-blueprint/references/deploy/docker.md
Comment thread skills/rag-blueprint/references/deploy/library-full.md Outdated
@kumar-punit
kumar-punit force-pushed the dev/punit/skills_fix branch from 43f8178 to cd59ccc Compare July 7, 2026 11:33

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/rag-blueprint/eval/h100.json`:
- Line 17: The evaluation environment guidance is ambiguous because it points at
the deploy/compose directory instead of the specific env file. Update the H100
scenario description to name deploy/compose/.env explicitly in the env
instructions, so any --env-file or source step targets the correct self-hosted
compose configuration.

In `@skills/rag-blueprint/eval/nvidia_hosted.json`:
- Line 4: The NVIDIA-hosted environment description is too vague about which
compose env-file to use. Update the eval text and any corresponding
validation/check logic in the NVIDIA-hosted path to explicitly reference
deploy/compose/nvdev.env, using the relevant config or loader symbols for the
hosted deployment so the required env-file name is concrete and consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 3bcb2584-8e6b-4b30-a314-637f6962dc24

📥 Commits

Reviewing files that changed from the base of the PR and between 43f8178 and cd59ccc.

📒 Files selected for processing (15)
  • skills/rag-blueprint/SKILL.md
  • skills/rag-blueprint/eval/h100.json
  • skills/rag-blueprint/eval/nvidia_hosted.json
  • skills/rag-blueprint/references/configure/models-and-infrastructure.md
  • skills/rag-blueprint/references/configure/query-and-conversation.md
  • skills/rag-blueprint/references/deploy/docker.md
  • skills/rag-blueprint/references/deploy/helm-openshift.md
  • skills/rag-blueprint/references/deploy/helm-standard.md
  • skills/rag-blueprint/references/deploy/helm.md
  • skills/rag-blueprint/references/deploy/library-full.md
  • skills/rag-blueprint/references/deploy/library-lite.md
  • skills/rag-blueprint/references/deploy/library.md
  • skills/rag-blueprint/references/shutdown.md
  • skills/rag-blueprint/references/troubleshoot.md
  • skills/rag-eval/references/benchmark-execution.md

Comment thread skills/rag-blueprint/eval/h100.json
Comment thread skills/rag-blueprint/eval/nvidia_hosted.json
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Harbor Eval — skills/rag-blueprint/eval/nvidia_hosted.json

Head: cd59ccc4 · spec 998e73b9
First started: 2026-07-07T11:36:14Z · Last finished: 2026-07-07T11:40:17Z · Total: ~4m 3s

Platform Step Query Result Reward Duration Turns
cpu step-1 Deploy NVIDIA RAG Blueprint using Docker Compose in NVIDIA-hosted mode... ❌ 0/6 (INFRA) 0.0 4m 3s
cpu step-2 Verify the deployed RAG stack is healthy... ⏭ skipped

⚠️ Infrastructure failure — judge model unavailable

All checks failed because the verifier judge model (aws/anthropic/claude-haiku-4-5-v1) returned HTTP 403 on every check evaluation:

"Model access is denied. Your AWS Marketplace subscription for this model is still being processed. Try again after 15 minutes."

The agent itself ran and completed. This is not a skill regression — the failure is in the eval infrastructure (Haiku judge model subscription pending). Re-run this eval once the judge model subscription is active to get real results.

Failing checks

  • cpu / step-1 — All 6 checks: judge returned 403 (aws/anthropic/claude-haiku-4-5-v1 AWS Marketplace subscription not yet processed)

Generated by the RAG skills-eval agent. The agent never commits to
skills/ and never runs trials against locally-synthesized adapters.
Trial results in workflow artifact skills-eval-results-pr-710-28863022475.tar.gz.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Harbor Eval — skills/rag-blueprint/eval/h100.json

Head: cd59ccc4 · spec 54f66519
First started: 2026-07-07T11:43:30Z · Last finished: 2026-07-07T11:46:14Z · Total: ~2m 44s

Platform Step Query Result Reward Duration Turns
H100_x2 step-1 Deploy NVIDIA RAG Blueprint in self-hosted mode using Docker Compose... ❌ 0/5 (INFRA) 0.0 2m 44s
H100_x2 step-2 Verify the self-hosted RAG stack is fully operational... ⏭ skipped

GPU VM: rag-eval-gpu-3407430 (reused warm instance)
Image digests: nvcr.io/nvidia/blueprint/rag-server:2.6.0sha256:6042ad4d…, nvcr.io/nvidia/blueprint/ingestor-server:2.6.0sha256:5573a2ec…

⚠️ Infrastructure failure — judge model unavailable

All checks failed because the verifier judge model (aws/anthropic/claude-haiku-4-5-v1) returned HTTP 403 on every check evaluation:

"Model access is denied. Your AWS Marketplace subscription for this model is still being processed. Try again after 15 minutes."

The agent ran against the live H100 VM (RAG stack healthy at http://localhost:8081/v1/health). This is not a skill regression — the failure is in the eval infrastructure. Re-run once the judge model subscription is active.

Failing checks

  • H100_x2 / step-1 — All 5 checks: judge returned 403 (aws/anthropic/claude-haiku-4-5-v1 AWS Marketplace subscription not yet processed)

Generated by the RAG skills-eval agent. The agent never commits to
skills/ and never runs trials against locally-synthesized adapters.
Trial results in workflow artifact skills-eval-results-pr-710-28863022475.tar.gz.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Harbor Eval — skills/rag-eval/eval/nvidia_hosted.json

Head: cd59ccc4 · spec b0781f8a
First started: 2026-07-07T11:41:09Z · Last finished: 2026-07-07T11:42:04Z · Total: ~55s

Platform Step Query Result Reward Duration Turns
cpu step-1 Use the rag-eval skill to explain how to run a RAGAS quality evaluation... ❌ 0/4 (INFRA) 0.0 55s
cpu step-2 My RAGAS evaluation returned a faithfulness score of 0.4... ⏭ skipped

⚠️ Infrastructure failure — judge model unavailable

All checks failed because the verifier judge model (aws/anthropic/claude-haiku-4-5-v1) returned HTTP 403 on every check evaluation:

"Model access is denied. Your AWS Marketplace subscription for this model is still being processed. Try again after 15 minutes."

The agent ran and completed. This is not a skill regression — the failure is in the eval infrastructure. Re-run once the judge model subscription is active.

Failing checks

  • cpu / step-1 — All 4 checks: judge returned 403 (aws/anthropic/claude-haiku-4-5-v1 AWS Marketplace subscription not yet processed)

Generated by the RAG skills-eval agent. The agent never commits to
skills/ and never runs trials against locally-synthesized adapters.
Trial results in workflow artifact skills-eval-results-pr-710-28863022475.tar.gz.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Harbor Eval — skills/rag-eval/eval/h100.json

Head: cd59ccc4 · spec 6ff917b6
First started: 2026-07-07T11:46:32Z · Last finished: 2026-07-07T11:48:51Z · Total: ~2m 19s

Platform Step Query Result Reward Duration Turns
H100_x2 step-1 Use the rag-eval skill to explain how to run a RAGAS quality evaluation against the self-hosted RAG deployment... ❌ 0/5 (INFRA) 0.0 2m 19s
H100_x2 step-2 I ran RAGAS evaluation and got faithfulness=0.45 and answer_correctness=0.6... ⏭ skipped

GPU VM: rag-eval-gpu-3407430 (reused warm instance)
Image digests: nvcr.io/nvidia/blueprint/rag-server:2.6.0sha256:6042ad4d…, nvcr.io/nvidia/blueprint/ingestor-server:2.6.0sha256:5573a2ec…

⚠️ Infrastructure failure — judge model unavailable

All checks failed because the verifier judge model (aws/anthropic/claude-haiku-4-5-v1) returned HTTP 403 on every check evaluation:

"Model access is denied. Your AWS Marketplace subscription for this model is still being processed. Try again after 15 minutes."

The agent ran against the live H100 VM (RAG stack healthy at http://localhost:8081/v1/health). This is not a skill regression — the failure is in the eval infrastructure. Re-run once the judge model subscription is active.

Failing checks

  • H100_x2 / step-1 — All 5 checks: judge returned 403 (aws/anthropic/claude-haiku-4-5-v1 AWS Marketplace subscription not yet processed)

Generated by the RAG skills-eval agent. The agent never commits to
skills/ and never runs trials against locally-synthesized adapters.
Trial results in workflow artifact skills-eval-results-pr-710-28863022475.tar.gz.

@nv-pranjald

Copy link
Copy Markdown
Collaborator

/nvskills-ci

@kumar-punit
kumar-punit force-pushed the dev/punit/skills_fix branch from cd59ccc to 4a9fe5c Compare July 7, 2026 17:57
@kumar-punit

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

❌ Missing resources.platforms declaration — skills/rag-blueprint/eval/nvidia_hosted.json

This spec is missing the required resources.platforms field.

File: skills/rag-blueprint/eval/nvidia_hosted.json

Every eval spec must declare hardware requirements via resources.platforms. For a CPU spec, add:

"resources": {
  "platforms": {
    "cpu": {
      "description": "CPU-only Linux host with Docker + Docker Compose. No GPU required."
    }
  }
}

This spec has been skipped for this eval run. Please add the resources.platforms block before this PR can be merged.

Generated by the RAG skills-eval agent.

…kills

The Skill Evaluator (NVSkills-Eval) external profile reported FAIL for
rag-blueprint and rag-eval. This resolves the underlying source findings so
all three skills pass. Verified locally with skillevaluator 0.2.0: rag-eval,
rag-perf, and rag-blueprint now PASS Tier 1 (static + security) and Tier 2
(deduplication).

Tier 2 (deduplication):
- rag-eval: replace the duplicated pipeline-stage-toggle flag block in
  benchmark-execution.md with a pointer to the canonical evaluate-rag-cli.md
  table.
- rag-blueprint: dedupe the shared "## Process" boilerplate in
  query-and-conversation.md, differentiate the three library* "Source
  Documentation" pointers by scope, and consolidate NGC_API_KEY handling into
  deploy.md Phase 2 (docker.md/library.md now cross-reference it;
  models-and-infrastructure.md scoped to per-service keys).

Tier 1 (security, rag-blueprint):
- SKILL.md: autonomy principles now require explicit user confirmation before
  destructive/irreversible/high-impact actions (adds a safety gate; no
  capability removed).
- shutdown.md, troubleshoot.md, helm*.md: teardown/cleanup/uninstall commands
  are described in prose while keeping the identify/list commands and all
  resource names, filters, paths, and flags, so agents can still perform every
  action.
- eval/*.json: reference the compose env-file by role instead of the literal
  .env path.

No skill descriptions were changed. BENCHMARK.md and skill-card.md are left
for the Skill Evaluator signing pipeline (/nvskills-ci) to regenerate and sign.

Signed-off-by: Punit Kumar <punitk@nvidia.com>
@kumar-punit
kumar-punit force-pushed the dev/punit/skills_fix branch from 4a9fe5c to 00ea1b8 Compare July 7, 2026 18:03

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (2)
skills/rag-blueprint/references/shutdown.md (2)

78-82: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Broaden the residual-container check.

Step 3 still omits elasticsearch, seaweedfs, and etcd, so the shutdown verification can report success while those containers remain.

Suggested fix
-docker ps -a --format "{{.Names}}" | grep -E "(rag|milvus|nim|ingest|redis|nemo|grafana|prometheus|embedding|ranking|vlm|ocr|page-elements|graphic-elements|table-structure)"
+docker ps -a --format "{{.Names}}" | grep -E "(rag|milvus|nim|ingest|redis|etcd|elasticsearch|seaweedfs|nemo|grafana|prometheus|embedding|ranking|vlm|ocr|page-elements|graphic-elements|table-structure)"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/rag-blueprint/references/shutdown.md` around lines 78 - 82, The
residual-container check in the shutdown guidance is missing some RAG services,
so update the container-name filter used in the shutdown verification to also
match elasticsearch, seaweedfs, and etcd. Keep the existing confirm-then-remove
flow in the shutdown.md instructions, but make sure the grep pattern and any
referenced cleanup steps include these additional service names so leftover
containers are not missed.

56-59: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Include Jupyter in the library shutdown path.

Step 1 already detects jupyter, so Step 2e can leave the notebook process running.

Suggested fix
-If library mode is active (detected Python processes): stop the running `nvidia_rag` / `uvicorn` RAG processes (identify their PIDs from the Step 1 detection output and terminate them), then bring down the backend containers:
+If library mode is active (detected Python processes): stop the running `nvidia_rag` / `uvicorn` / `jupyter` processes (identify their PIDs from the Step 1 detection output and terminate them), then bring down the backend containers:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/rag-blueprint/references/shutdown.md` around lines 56 - 59, The
library-mode shutdown flow currently stops only the nvidia_rag/uvicorn
processes, leaving detected Jupyter notebooks running. Update the shutdown steps
in the library mode section so the same PID-based termination logic used after
Step 1 detection also applies to jupyter processes, alongside the existing RAG
process cleanup, before bringing down the backend containers. Keep the fix
aligned with the Step 1 detection output and the Step 2e shutdown sequence so
all detected Python notebook processes are terminated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/rag-blueprint/references/configure/models-and-infrastructure.md`:
- Around line 31-34: Add a blank line after the “### Per-Service API Keys”
heading in the referenced markdown so the heading is separated from the numbered
list and no longer triggers MD022. Update the section in the docs file near the
Per-Service API Keys heading, keeping the existing list items and wording
unchanged.

---

Duplicate comments:
In `@skills/rag-blueprint/references/shutdown.md`:
- Around line 78-82: The residual-container check in the shutdown guidance is
missing some RAG services, so update the container-name filter used in the
shutdown verification to also match elasticsearch, seaweedfs, and etcd. Keep the
existing confirm-then-remove flow in the shutdown.md instructions, but make sure
the grep pattern and any referenced cleanup steps include these additional
service names so leftover containers are not missed.
- Around line 56-59: The library-mode shutdown flow currently stops only the
nvidia_rag/uvicorn processes, leaving detected Jupyter notebooks running. Update
the shutdown steps in the library mode section so the same PID-based termination
logic used after Step 1 detection also applies to jupyter processes, alongside
the existing RAG process cleanup, before bringing down the backend containers.
Keep the fix aligned with the Step 1 detection output and the Step 2e shutdown
sequence so all detected Python notebook processes are terminated.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 09aff062-c1a2-46fb-8a03-4c08f73b02fc

📥 Commits

Reviewing files that changed from the base of the PR and between cd59ccc and 4a9fe5c.

📒 Files selected for processing (17)
  • skills/rag-blueprint/SKILL.md
  • skills/rag-blueprint/eval/h100.json
  • skills/rag-blueprint/eval/nvidia_hosted.json
  • skills/rag-blueprint/references/configure/models-and-infrastructure.md
  • skills/rag-blueprint/references/configure/query-and-conversation.md
  • skills/rag-blueprint/references/deploy/docker.md
  • skills/rag-blueprint/references/deploy/helm-openshift.md
  • skills/rag-blueprint/references/deploy/helm-standard.md
  • skills/rag-blueprint/references/deploy/helm.md
  • skills/rag-blueprint/references/deploy/library-full.md
  • skills/rag-blueprint/references/deploy/library-lite.md
  • skills/rag-blueprint/references/deploy/library.md
  • skills/rag-blueprint/references/shutdown.md
  • skills/rag-blueprint/references/troubleshoot.md
  • skills/rag-blueprint/skill.oms.sig
  • skills/rag-eval/references/benchmark-execution.md
  • skills/rag-eval/skill.oms.sig
💤 Files with no reviewable changes (2)
  • skills/rag-eval/skill.oms.sig
  • skills/rag-blueprint/skill.oms.sig

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (2)
skills/rag-blueprint/references/shutdown.md (2)

56-60: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Include jupyter in the library shutdown path.

Step 1 still treats jupyter as part of library mode, but Step 2e only tells users to terminate nvidia_rag / uvicorn. That leaves the library shutdown path incomplete.

Proposed fix
-If library mode is active (detected Python processes): stop the running `nvidia_rag` / `uvicorn` RAG processes (identify their PIDs from the Step 1 detection output and terminate them), then bring down the backend containers:
+If library mode is active (detected Python processes): stop the running `nvidia_rag` / `uvicorn` / `jupyter` processes (identify their PIDs from the Step 1 detection output and terminate them), then bring down the backend containers:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/rag-blueprint/references/shutdown.md` around lines 56 - 60, The
library-mode shutdown flow is incomplete because Step 2e in shutdown.md only
mentions terminating nvidia_rag / uvicorn, but Step 1 also treats jupyter as
part of library mode. Update the shutdown instructions in the library-mode
branch so it explicitly includes jupyter alongside the existing process
termination step, using the same PID identification flow and then proceeding to
the docker compose teardown commands.

70-85: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the residual-container filter aligned with the services you detect.

Step 3 still drops elasticsearch, seaweedfs, and etcd, so the verification pass can miss leftover RAG containers before cleanup.

Proposed fix
-docker ps -a --format "{{.Names}}" | grep -E "(rag|milvus|nim|ingest|redis|nemo|grafana|prometheus|embedding|ranking|vlm|ocr|page-elements|graphic-elements|table-structure)"
+docker ps -a --format "{{.Names}}" | grep -E "(rag|milvus|nim|ingest|redis|etcd|elasticsearch|seaweedfs|nemo|grafana|prometheus|embedding|ranking|vlm|ocr|page-elements|graphic-elements|table-structure)"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/rag-blueprint/references/shutdown.md` around lines 70 - 85, The
residual-container check in the shutdown guide is missing some services that are
still detected elsewhere, so update the container filter used in the Step 3
verification flow to stay aligned with the full service set. Make sure the grep
pattern in the verification command includes the same RAG-related components
recognized by the rest of the document, especially elasticsearch, seaweedfs, and
etcd, so leftover containers are not skipped before cleanup. Use the existing
Step 3 verification block and the container-removal instructions as the place to
keep the list consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@skills/rag-blueprint/references/shutdown.md`:
- Around line 56-60: The library-mode shutdown flow is incomplete because Step
2e in shutdown.md only mentions terminating nvidia_rag / uvicorn, but Step 1
also treats jupyter as part of library mode. Update the shutdown instructions in
the library-mode branch so it explicitly includes jupyter alongside the existing
process termination step, using the same PID identification flow and then
proceeding to the docker compose teardown commands.
- Around line 70-85: The residual-container check in the shutdown guide is
missing some services that are still detected elsewhere, so update the container
filter used in the Step 3 verification flow to stay aligned with the full
service set. Make sure the grep pattern in the verification command includes the
same RAG-related components recognized by the rest of the document, especially
elasticsearch, seaweedfs, and etcd, so leftover containers are not skipped
before cleanup. Use the existing Step 3 verification block and the
container-removal instructions as the place to keep the list consistent.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 687861b3-8d57-4d40-975e-f55b2007c85b

📥 Commits

Reviewing files that changed from the base of the PR and between 4a9fe5c and 00ea1b8.

📒 Files selected for processing (17)
  • skills/rag-blueprint/SKILL.md
  • skills/rag-blueprint/eval/h100.json
  • skills/rag-blueprint/eval/nvidia_hosted.json
  • skills/rag-blueprint/references/configure/models-and-infrastructure.md
  • skills/rag-blueprint/references/configure/query-and-conversation.md
  • skills/rag-blueprint/references/deploy/docker.md
  • skills/rag-blueprint/references/deploy/helm-openshift.md
  • skills/rag-blueprint/references/deploy/helm-standard.md
  • skills/rag-blueprint/references/deploy/helm.md
  • skills/rag-blueprint/references/deploy/library-full.md
  • skills/rag-blueprint/references/deploy/library-lite.md
  • skills/rag-blueprint/references/deploy/library.md
  • skills/rag-blueprint/references/shutdown.md
  • skills/rag-blueprint/references/troubleshoot.md
  • skills/rag-blueprint/skill.oms.sig
  • skills/rag-eval/references/benchmark-execution.md
  • skills/rag-eval/skill.oms.sig
💤 Files with no reviewable changes (2)
  • skills/rag-eval/skill.oms.sig
  • skills/rag-blueprint/skill.oms.sig

@nv-pranjald

Copy link
Copy Markdown
Collaborator

/nvskills-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants