Adding additional log coverage#1503
Merged
Merged
Conversation
|
Looks good. All 22 mutations in this change were killed.
|
| logRequest(STRUCTURED_LOG_TEMPLATE, structuredTaskDefinition, | ||
| gpcConfiguration.getUrl() + gpcConfiguration.getMigrateStructuredEndpoint()); | ||
|
|
||
| long startTime = System.currentTimeMillis(); |
Contributor
There was a problem hiding this comment.
random Q but why do we use long here?
Contributor
Author
There was a problem hiding this comment.
Miliseconds quite be quite long hence safer to declare them as "long" rather than as "int".
Collaborator
There was a problem hiding this comment.
main reason is:
This method returns the difference, measured in milliseconds, between the current time and midnight, January 1, 1970 UTC(coordinated universal time). - Thats a pretty big number so the method returns long as int has a max value of 2147483647
chiaramapellimt
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adding additional log coverage
Why
Log coverage is an essential part of the application and helps to investigate different issues and cases.
Type of change
Please delete options that are not relevant.
Checklist: