show encapsulated types via inspect()#607
Open
dotnetCarpenter wants to merge 1 commit intoMostlyAdequate:masterfrom
Open
show encapsulated types via inspect()#607dotnetCarpenter wants to merge 1 commit intoMostlyAdequate:masterfrom
dotnetCarpenter wants to merge 1 commit intoMostlyAdequate:masterfrom
Conversation
This was referenced Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to understand the examples in this book, I usually
console.logthe compositions in node but whenever an ADT encapsulates another ADT, I get confusing output. I sometimes thought I was looking at a bug but this PR will fix that :)Not only that but it will fix a case that currently will throw a
TypeError.Here is what I used to test the improved
inspectfunction with:Currently the output will be:
Contrast that with the following, with this patch applied:
If both PR #605 and #606 is applied then the following is also possible (and
identity1(Either.of('stuff'))is no longerundefined):The output is now:
That is all of the ADT's except
Composewhich is in a closure, so I can not pattern match on theComposeconstructor at the moment.