Skip to content

New metrics are added for imbalanced data#480

Closed
mcavs wants to merge 2 commits into
ModelOriented:masterfrom
mcavs:patch-1
Closed

New metrics are added for imbalanced data#480
mcavs wants to merge 2 commits into
ModelOriented:masterfrom
mcavs:patch-1

Conversation

@mcavs

@mcavs mcavs commented Feb 20, 2022

Copy link
Copy Markdown

Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.

Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.

@hbaniecki hbaniecki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hbaniecki hbaniecki self-requested a review February 21, 2022 12:14
Comment thread R/model_performance.R Outdated

@pbiecek pbiecek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcavs thank you,
for onboarding of new code please:

This was referenced Feb 21, 2022
@mcavs

mcavs commented Feb 21, 2022

Copy link
Copy Markdown
Author

@pbiecek 2 added and 3 updated, but I do not know how to add unit test :/

@hbaniecki

Copy link
Copy Markdown
Member

Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files).

@mcavs

mcavs commented May 10, 2022

Copy link
Copy Markdown
Author

Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files).

Hi @hbaniecki, I created a new pull request consists 2 and 3. You can see it on #505

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants