Fix getAssetsIndex task for FG1.0#1075
Open
zeng-github01 wants to merge 2 commits into
Open
Conversation
zeng-github01
force-pushed
the
FG_1.0-assets-download
branch
from
954e0eb to
57c9ee0
Compare
LexManos
reviewed
May 22, 2026
| public static final OperatingSystem OPERATING_SYSTEM = getOs(); | ||
| public static final SystemArch SYSTEM_ARCH = getArch(); | ||
| public static final String HASH_FUNC = "MD5"; | ||
| public static final String USER_AGENT = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11"; |
Member
There was a problem hiding this comment.
Do not run code formatters over existing code.
It makes your entire change set a pain to actually read/understand
LexManos
reviewed
May 22, 2026
| public static final String FERNFLOWER = "{CACHE_DIR}/minecraft/fernflower.jar"; | ||
| public static final String EXCEPTOR = "{CACHE_DIR}/minecraft/exceptor.jar"; | ||
| public static final String ASSETS = "{CACHE_DIR}/minecraft/assets"; | ||
| public static final String JSONS_DIR = "{CACHE_DIR}/minecraft/versionJsons"; |
Member
There was a problem hiding this comment.
Don't use upper cases in directory names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LexManos Please review it