chore: add ohlcv websocket streaming by sahar-fehri · Pull Request #29739 · MetaMask/metamask-mobile

sahar-fehri · 2026-05-05T14:17:04Z

Description

Related to: https://www.notion.so/metamask-consensys/OHLCV-WebSocket-Integration-UI-Implementation-Guide-346f86d67d6880b6a70fc3be0f0c34b9

Wires OHLCVService from @metamask/core-backend into the Engine and creates a useOHLCVRealtime hook that streams live candlestick updates to the advanced chart via the existing realtimeBar prop on AdvancedChart.

Why: The advanced chart currently only renders historical data fetched via the REST OHLCV API. Users see stale candles until they navigate away and back. Real-time streaming via WebSocket keeps the chart live with 5-second heartbeat updates.

How: Follows the exact same Engine wiring pattern as AccountActivityService — messenger, init function, Engine registration. The new useOHLCVRealtime hook subscribes to OHLCVService:barUpdated events, filters by channel, and converts the WS bar format (timestamp in Unix seconds) to the chart's expected format (time in milliseconds).

Manual Test Plan

Prerequisites

MetaMask Mobile connected to a wallet with tokens
backendWebSocketConnection feature flag enabled

Adding console.log statements to the mobile hook

1. Inside handleBarUpdated — after the channel guard:

const handleBarUpdated = (payload: { channel: string; bar: WSOHLCVBar }) => {
  if (payload.channel === channelRef.current) {
    console.log(                                                        // ← ADD
      `[OHLCV-WS] Bar received — channel=${payload.channel}, close=${payload.bar.close}, ts=${payload.bar.timestamp}`,
    );
    lastMessageTimeRef.current = Date.now();
    ...

2. Inside handleSubscriptionError — first line of the callback:

const handleSubscriptionError = (payload: { channel: string; error: string; operation: string }) => {
  console.log(                                                          // ← ADD
    `[OHLCV-WS] Subscription error on ${payload.channel}: ${payload.error} (${payload.operation})`,
  );
};

3. Inside handleChainStatusChanged — after the chainIds.includes guard:

if (payload.chainIds.includes(chainId)) {
  console.log(                                                          // ← ADD
    `[OHLCV-WS] Chain status changed — chainId=${chainId}, status=${payload.status}`,
  );
  chainDownRef.current = payload.status === 'down';
}

4. Inside pollLatest — first line of the function:

const pollLatest = async () => {
  pollingAbortRef.current?.abort();
  const controller = new AbortController();
  pollingAbortRef.current = controller;

  console.log('[OHLCV-WS] Polling /latest via REST fallback');          // ← ADD
  ...

5. Inside the staleness setInterval — when isStale || chainDown:

if (isStale || chainDownRef.current) {
  console.log(                                                          // ← ADD
    `[OHLCV-WS] Stream stale or chain down — isStale=${isStale}, chainDown=${chainDownRef.current}, elapsed=${elapsed}ms`,
  );
  pollLatest();
}

6. Inside the debounce setTimeout — first line:

debounceTimerRef.current = setTimeout(async () => {
  console.log(                                                          // ← ADD
    `[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for ${channel}`,
  );
  try {
    await Engine.controllerMessenger.call('OHLCVService:subscribe', { ... });
    ...

7. In the cleanup return function — first line:

return () => {
  console.log(                                                          // ← ADD
    `[OHLCV-WS] Cleanup — channel=${channel}, wasSubscribed=${subscribedRef.current}`,
  );
  cancelledRef.current = true;
  ...

Enabling core logs in the debugger

By default, core OHLCVService logs use projectLogger (the debug package) and won't appear in the React Native debugger. To make them visible, open:

node_modules/@metamask/core-backend/dist/ws/ohlcv/OHLCVService.cjs

Find this line (near the top, around line 30):

const log = (0, logger_1.createModuleLogger)(logger_1.projectLogger, SERVICE_NAME);

Replace with:

const log = (...args) => console.log('[OHLCV-WS]', ...args);

Now all core logs will appear in the debugger with the [OHLCV-WS] prefix, alongside the mobile hook logs. Revert with yarn install when done.

Group A — No Code Changes (Just Tap and Observe)

Scenario 1: Basic WebSocket Subscription

Steps:

Open Token Details for a supported token (e.g., ETH on Base)
Wait for historical chart to load
Observe logs

Expected logs:

[OHLCV-WS] OHLCV-WS: Initializing — registering system-notifications callback
[OHLCV-WS] OHLCV-WS: Resubscribing active channels after reconnect {count: 0}
[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1986.69, ts=1778538600

Note: Resubscribing active channels after reconnect {count: 0} appears at app boot because AccountActivityService opened the shared WebSocket first. OHLCVService hears the CONNECTED event and checks for channels to restore — finds zero since no subscription exists yet. This is normal.

Verify: Bars continue arriving every ~5s with updating close prices.

Scenario 2: Navigate Away (Unsubscribe + Grace Period)

Steps:

From Scenario 1, press back to leave Token Details
Wait 3+ seconds
Observe logs

Expected logs:

[OHLCV-WS] Cleanup — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, wasSubscribed=true
[OHLCV-WS] OHLCV-WS: Grace period expired — performing actual WS unsubscribe {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] OHLCV-WS: WS unsubscribe completed {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}

Verify: No more bar updates after grace period expires.

Scenario 3: Rapid Navigation (Grace Period Cancel)

Steps:

Open Token Details for Token A, wait for subscription
Navigate back
Immediately re-open Token A (within 3 seconds)

Expected logs:

[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Cleanup — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, wasSubscribed=true
[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Cancelled grace-period unsubscribe, bumped refCount {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur', refCount: 1}

Verify: Cancelled grace-period unsubscribe, bumped refCount appears — subscription was reused without a server roundtrip.

Scenario 4: Switch Between Tokens

Steps:

Open Token Details for Token A (e.g. ETH on Base), wait for subscription
Navigate back to token list
Open Token B (e.g. MNT on Ethereum)

Expected logs:

[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1988.32, ts=1778539500
[OHLCV-WS] Cleanup — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, wasSubscribed=true
[OHLCV-WS] OHLCV-WS: Grace period expired — performing actual WS unsubscribe {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] OHLCV-WS: WS unsubscribe completed {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:1/erc20:0x3c3a...15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:1/erc20:0x3c3a...15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:1/erc20:0x3c3a...15m.eur, close=0.59, ts=1778539500

Verify: Token A fully unsubscribes (grace period expires). Token B gets its own subscription and bars flow.

Scenario 5: Rapid Time Range Switching

Steps:

Open Token Details, wait for bars on default time range (15m)
Rapidly switch between time ranges (e.g. 1H → 1D → 1W → 1H)

Expected logs (showing one switch cycle: 15m → 1h):

[OHLCV-WS] Cleanup — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, wasSubscribed=true
[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.1h.eur
[OHLCV-WS] OHLCV-WS: Flushing grace-period channel before new subscribe {flushedChannel: '...15m.eur', newChannel: '...1h.eur'}
[OHLCV-WS] OHLCV-WS: Grace period expired — performing actual WS unsubscribe {channel: '...15m.eur'}
[OHLCV-WS] OHLCV-WS: WS unsubscribe completed {channel: '...15m.eur'}
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: '...1h.eur'}

This pattern repeats for each switch (1h → 1d → 1h → 15m → 1m). Each time, the old channel is flushed immediately before the new subscribe — no accumulation, no server rejections.

Verify: Every subscribe succeeds (Subscribe succeeded). Flushing grace-period channel appears before each new subscribe. Bars flow on the final time range.

Scenario 6: App Background / Foreground

Steps:

Open Token Details for a supported token, wait for bars to flow
Press home button (send app to background)
Wait ~10 seconds
Bring app back to foreground

Expected logs:

[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1987.42, ts=1778540400
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1987.37, ts=1778540400
— app sent to background, then brought back —
[OHLCV-WS] OHLCV-WS: Resubscribing active channels after reconnect {count: 1}
[OHLCV-WS] OHLCV-WS: Resubscription succeeded {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1987.18, ts=1778540400

Verify: Resubscribing active channels after reconnect {count: 1} appears after foregrounding. Bars resume automatically without user interaction.

Scenario 7: Unsupported Token (No OHLCV Data)

Steps:

Open Token Details for a token with no OHLCV API data

Expected: No WS subscription, falls back to legacy line chart.

Group B — Requires Changing DEV Constants in `useOHLCVRealtime.ts`

After testing, set both constants back to 0 before committing.

Scenario 8: WebSocket Disconnect → REST Polling Fallback

What this tests: The WebSocket connection drops and stays disconnected. After the staleness threshold (30s) is exceeded, the hook falls back to polling REST.

Code to add

In useOHLCVRealtime.ts, set the DEV constant:

const DEV_SIMULATE_WS_DISCONNECT_AFTER_MS = 10000; // ← ACTIVE

The simulation code in the hook must call disconnect (clean shutdown, not forceReconnection):

if (DEV_SIMULATE_WS_DISCONNECT_AFTER_MS > 0) {
  setTimeout(() => {
    console.log(
      `[OHLCV-WS] DEV: Simulating WS disconnect (no reconnect) after ${DEV_SIMULATE_WS_DISCONNECT_AFTER_MS}ms`,
    );
    Engine.controllerMessenger.call(
      'BackendWebSocketService:disconnect' as never,
    );
  }, DEV_SIMULATE_WS_DISCONNECT_AFTER_MS);
}

How it works

After 10s, calls BackendWebSocketService:disconnect (clean shutdown, no auto-reconnect). The WS stays dead. After 30s with no bars, staleness triggers REST polling every 15s.

Steps to test

Set the constants as shown above
Rebuild / hot-reload the app
Open Token Details for a supported token
Wait for bars to start flowing (~5s)
At 10s, the simulated disconnect fires automatically
Wait ~30s for the staleness threshold
Observe REST fallback polling in logs

Expected logs:

[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscribe succeeded — new WS subscription created {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur'}
[OHLCV-WS] Bar received — channel=market-data.v1.eip155:8453/slip44:60.15m.eur, close=1985.08, ts=1778540400
[OHLCV-WS] DEV: Simulating WS disconnect (no reconnect) after 10000ms
[OHLCV-WS] Stream stale or chain down — isStale=true, chainDown=false, elapsed=38975ms
[OHLCV-WS] Polling /latest via REST fallback
[OHLCV-WS] Stream stale or chain down — isStale=true, chainDown=false, elapsed=44886ms
[OHLCV-WS] Polling /latest via REST fallback

Verify: After the simulated disconnect, no more Bar received logs. REST polling kicks in every 15s once staleness threshold (30s) is exceeded.

Group C — Requires Editing `.cjs` in node_modules

After testing, run yarn install in the mobile repo to restore the original file.

Scenario 10: Subscribe Failure / Error Recovery

What this tests: OHLCVService.subscribe() fails. The service catches the error, publishes OHLCVService:subscriptionError, forces reconnection, and REST fallback keeps the chart alive.

Code to add

1. Disable dev simulation constant in useOHLCVRealtime.ts:

const DEV_SIMULATE_WS_DISCONNECT_AFTER_MS = 0;

2. Simulate subscribe failure — open node_modules/@metamask/core-backend/dist/ws/ohlcv/OHLCVService.cjs.

Find the subscribe call (look for BackendWebSocketService:subscribe) and comment it out, then add a throw:

// await __classPrivateFieldGet(this, _OHLCVService_messenger, "f").call('BackendWebSocketService:subscribe', {
//     channels: [channel],
//     channelType: SUBSCRIPTION_NAMESPACE,
//     callback: (notification) => {
//         __classPrivateFieldGet(this, _OHLCVService_instances, "m", _OHLCVService_handleBarUpdate).call(this, channel, notification);
//     },
// });
throw new Error('DEV: Simulated subscribe failure — invalid channel');

Steps to test

Apply both code changes above
Reload the app
Open Token Details for a supported token
Observe logs

Expected — look for these key logs:

[OHLCV-WS] OHLCV-WS: Resubscribing active channels after reconnect {count: 0}
[OHLCV-WS] Debounce fired — calling OHLCVService:subscribe for market-data.v1.eip155:8453/slip44:60.15m.eur
[OHLCV-WS] OHLCV-WS: Subscription failed, forcing reconnection {channel: 'market-data.v1.eip155:8453/slip44:60.15m.eur', error: Error: Test error ...}
[OHLCV-WS] Subscription error on market-data.v1.eip155:8453/slip44:60.15m.eur: Error: Test error (subscribe)
[OHLCV-WS] OHLCV-WS: Forcing WebSocket reconnection
[OHLCV-WS] OHLCV-WS: Resubscribing active channels after reconnect {count: 0}
[OHLCV-WS] Stream stale or chain down — isStale=true, chainDown=false, elapsed=44219ms
[OHLCV-WS] Polling /latest via REST fallback

Verify: Error is caught, reconnection attempted (Forcing WebSocket reconnection), and REST fallback keeps chart alive after staleness is detected.

Log Reference

All logs use the OHLCV-WS prefix. Filter by OHLCV-WS in Flipper / debugger.

Changelog

CHANGELOG entry: Adds websocket streaming integration for ohlcv data

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3194?atlOrigin=eyJpIjoiYmQ4N2E3MTlmZTFlNGYyNGFiODUxNzA2YThmM2FkYTkiLCJwIjoiaiJ9
Related: MetaMask/core#8695

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Introduces a new Engine-integrated WebSocket service and a real-time data path for price charts, which could impact app lifecycle, network subscriptions, and chart correctness if misconfigured. Includes a REST polling fallback and feature-flag gating, reducing blast radius but still touching core infrastructure.

Overview
Adds real-time OHLCV candlestick streaming to the token details advanced chart by wiring OHLCVService (from @metamask/core-backend) into the Engine/messenger layer and upgrading @metamask/core-backend to ^6.3.0.

Introduces useOHLCVRealtime, which subscribes (debounced) to OHLCVService bar updates and provides a staleness/chain-down HTTP /latest fallback, then feeds updates into AdvancedChart via its existing realtimeBar prop.

Gates the behavior behind a new remote, version-gated feature flag tokenDetailsOhlcvWsIntegration (registry + selector + CI constant mapping) and updates related unit tests/mocks to account for the new hook and selector.

^{Reviewed by Cursor Bugbot for commit fe6f560. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-05-05T14:17:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-05-11T23:57:34Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@metamask/core-backend@6.2.2 ⏵ 6.3.0	⁺¹			⁺²

View full report

codecov-commenter · 2026-05-12T00:37:17Z

Codecov Report

❌ Patch coverage is 91.07143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.68%. Comparing base (3751d9a) to head (1d8190f).
⚠️ Report is 59 commits behind head on main.

Files with missing lines	Patch %	Lines
...onents/UI/Charts/AdvancedChart/useOHLCVRealtime.ts	91.95%	2 Missing and 5 partials ⚠️
...mponents/UI/AssetOverview/Price/Price.advanced.tsx	72.72%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #29739      +/-   ##
==========================================
+ Coverage   81.54%   81.68%   +0.13%     
==========================================
  Files        5343     5389      +46     
  Lines      142128   143476    +1348     
  Branches    32411    32756     +345     
==========================================
+ Hits       115899   117192    +1293     
+ Misses      18299    18266      -33     
- Partials     7930     8018      +88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sahar-fehri · 2026-05-12T00:46:18Z

    "@metamask/connectivity-controller": "^0.1.0",
    "@metamask/controller-utils": "^11.18.0",
-    "@metamask/core-backend": "^6.2.0",
+    "@metamask/core-backend": "npm:@metamask-previews/core-backend@6.2.2-preview-094d56fb3",


TODO: to be removed after release

sahar-fehri · 2026-05-12T07:26:21Z

  });

+  const wsInterval = WS_INTERVAL_BY_TIME_RANGE[timeRange];
+  // TODO: Check if we want to add a feature flag to gate the WS OHLCV feature


Could be a followup

…MetaMask#8695) ## Explanation ### Architecture Overview ``` ┌─────────────────┐ messenger ┌──────────────────────────┐ │ OHLCVService │ ─── calls actions ────► │ BackendWebSocketService │ │ (domain logic) │ │ (raw WS connection) │ │ │ ◄── listens to events ── │ │ └────────┬────────┘ └──────────┬───────────────┘ │ │ publishes events actual WebSocket to UI consumers (connect, auth, reconnect, heartbeat, JSON framing) │ ▼ ┌──────────────────┐ │ Mobile UI │ │ (React hooks) │ │ useOHLCVRealtime │ └──────────────────┘ ``` ### What - Add `OHLCVService` for real-time OHLCV (candlestick) data streaming via the backend WebSocket gateway - Move all WebSocket-related files (`BackendWebSocketService`, `AccountActivityService`) into a new `src/ws/` directory per code review feedback ### Why - Enable real-time chart updates on the Token Details screen without polling - Reduce API load by replacing periodic HTTP calls with persistent WebSocket subscriptions - Organize WebSocket code into a dedicated `ws/` folder for better discoverability ### New files - `src/ws/ohlcv/OHLCVService.ts` — main service with subscribe/unsubscribe semantics, reference counting, grace-period unsubscribe, idempotency checks, chain-status forwarding, and automatic resubscription on reconnect - `src/ws/ohlcv/OHLCVService.test.ts` — 22 unit tests covering all paths (100% branch coverage) - `src/ws/ohlcv/OHLCVService-method-action-types.ts` — auto-generated messenger action types - `src/ws/ohlcv/types.ts` — `OHLCVBar` and `OHLCVSubscriptionOptions` types - `src/ws/ohlcv/index.ts` — barrel exports ### Modified files - `src/index.ts` — added exports for `OHLCVService`, its types, and allowed actions/events; updated import paths to `./ws/` - `eslint-suppressions.json` — updated paths for moved files, added suppressions for new test file - `CHANGELOG.md` — documented new service and exports ### Moved files (no logic changes) - `src/BackendWebSocketService.ts` → `src/ws/BackendWebSocketService.ts` - `src/BackendWebSocketService.test.ts` → `src/ws/BackendWebSocketService.test.ts` - `src/BackendWebSocketService-method-action-types.ts` → `src/ws/BackendWebSocketService-method-action-types.ts` - `src/AccountActivityService.ts` → `src/ws/AccountActivityService.ts` - `src/AccountActivityService.test.ts` → `src/ws/AccountActivityService.test.ts` - `src/AccountActivityService-method-action-types.ts` → `src/ws/AccountActivityService-method-action-types.ts` - Only import path updates (`./logger` → `../logger`, `./types` → `../types`, test helper paths) ### Key design decisions - **UI-driven lifecycle** — unlike `AccountActivityService` (auto-subscribes on account change), `OHLCVService` exposes `subscribe()`/`unsubscribe()` called by the UI when the chart mounts/unmounts - **Reference counting** — multiple UI consumers subscribing to the same assetId/interval/currency share one WebSocket subscription - **Grace period (3s)** — when all consumers unsubscribe, actual WS unsubscribe is delayed 3 seconds to absorb rapid navigation (Token A → Token B → Token A) - **Idempotency** — uses `channelHasSubscription` before subscribing; duplicate calls are no-ops (React Strict Mode safe) - **Chain status** — listens to `system-notifications.v1.market-data.v1` (auto-subscribed by server) and publishes `OHLCVService:chainStatusChanged` - **Disconnect handling** — on WebSocket disconnect, publishes `chainStatusChanged { status: 'down' }` for all tracked chains, triggering UI polling fallback - **Reconnect** — resubscribes all active channels when WebSocket reconnects (no `sessionId` needed for OHLCV; UI polling fallback covers the gap) - **`init()` method** — system notification callback registered in `init()` (not constructor) to comply with messenger-in-constructor lint rule ### Events published - `OHLCVService:barUpdated` — `{ channel, bar: OHLCVBar }` — new candle data from WebSocket - `OHLCVService:chainStatusChanged` — `{ chainIds, status, timestamp? }` — chain up/down (server notification or WS disconnect) - `OHLCVService:subscriptionError` — `{ channel, error, operation }` — subscribe or unsubscribe failure ## References * Related to https://www.notion.so/metamask-consensys/OHLCV-WebSocket-Integration-UI-Implementation-Guide-346f86d67d6880b6a70fc3be0f0c34b9 * Related to MetaMask/metamask-mobile#29739 * Fixes https://consensyssoftware.atlassian.net/browse/ASSETS-3195 ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Medium Risk** > Adds a new WebSocket-driven market-data service with reference counting, timers, and reconnect resubscription logic, which can affect subscription lifecycles and event delivery. Also moves existing WebSocket services into `src/ws/`, so consumers relying on internal paths (vs package exports) could break if any remain. > > **Overview** > Adds a new `OHLCVService` to stream real-time OHLCV bars over WebSocket, exposing `subscribe`/`unsubscribe` via messenger actions, publishing `barUpdated`/`chainStatusChanged`/`subscriptionError` events, and handling reconnect resubscription with ref-counting plus a grace-period unsubscribe (mutex-protected). > > Refactors `core-backend` by moving `BackendWebSocketService` and `AccountActivityService` (and their tests/action-type files) into `src/ws/`, updating imports/exports (`src/index.ts`), and updating lint suppressions; also adds `async-mutex` plus comprehensive unit tests for the new service and documents the addition in the changelog. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 730af62. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Prithpal-Sooriya · 2026-05-14T10:57:37Z

Will wait for package bump before we can marge

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 88ec55d. Configure here.}

## Explanation  New minor release for core-backend. Preview with changes here: MetaMask/metamask-mobile#29739 ## References  ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: updates package versions/changelogs and bumps `@metamask/core-backend` dependency ranges without changing runtime code in this PR. > > **Overview** > Bumps the monorepo version to `984.0.0` and publishes `@metamask/core-backend@6.3.0` (updating its changelog and compare links). > > Updates `@metamask/assets-controller`, `@metamask/assets-controllers`, and `@metamask/transaction-controller` to depend on `@metamask/core-backend@^6.3.0`, with corresponding changelog entries and `yarn.lock` refresh. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1b7bb1a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions · 2026-05-14T14:42:26Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeWalletPlatform
Selected Performance tags: @PerformanceAssetLoading
Risk Level: medium
AI Confidence: 72%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new OHLCVService (real-time OHLCV candlestick WebSocket service) into the Engine, along with updates to the Price.advanced.tsx component for real-time chart data. Key observations:

Engine changes are additive and low-risk: The OHLCVService is added to STATELESS_NON_CONTROLLER_NAMES (no Redux state sync needed), follows the same pattern as AccountActivityService/BackendWebSocketService, and doesn't modify any existing controller initialization order or dependencies.
Feature flag gated (off by default): The tokenDetailsOhlcvWsIntegration flag defaults to enabled: false, so the WebSocket functionality won't activate in standard E2E tests.
Price.advanced.tsx changes: The advanced chart component is modified to integrate real-time bar updates. This component is part of the token details/asset overview screen, which falls under SmokeWalletPlatform (transaction history, wallet platform features, token display).
package.json bump: @metamask/core-backend bumped from ^6.2.0 to ^6.3.0 (minor, additive).
No impact on confirmations, accounts, networks, swaps, snaps, or other domains: The changes are isolated to the asset overview price chart and Engine service initialization.

SmokeWalletPlatform is selected to validate that:

The Engine still initializes correctly with the new OHLCVService
The token details/asset overview screen still renders correctly
The price chart component works with the new (feature-flag-gated) realtime integration
No regressions in wallet platform features

No other tags are needed as the changes are isolated to the asset overview/price chart domain and the new service is stateless and feature-flag gated.

Performance Test Selection:
The Price.advanced.tsx component now integrates a real-time WebSocket subscription (useOHLCVRealtime hook) with debouncing, staleness polling, and interval timers. Even though the feature is gated behind a feature flag (off by default), the component rendering path has changed with new useMemo/useEffect hooks and additional state management. The @PerformanceAssetLoading tag covers token list rendering, balance fetching, and portfolio value calculation - which includes the asset overview/token details screen where these changes live. This is worth validating to ensure the new hooks don't introduce render performance regressions even when the feature flag is disabled.

View GitHub Actions results

sonarqubecloud · 2026-05-14T14:58:01Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chore: add ohlcv websocket streaming

aeed743

sahar-fehri added 3 commits May 6, 2026 12:42

chore: integrate OHLCVService WebSocket streaming into advanced charts

6b18707

fix: add ohlcv latest fallback on disconnect or down

8748a32

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

5e5c781

github-actions Bot added the size-L label May 11, 2026

sahar-fehri added 5 commits May 11, 2026 12:14

fix: todo comment

6182bb7

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

5786c6c

fix: test log

ad5be51

fix: cleanup

edda0db

fix: lint

837b876

fix: ut

caefeb6

fix: fix ut

88c63a7

sahar-fehri commented May 12, 2026

View reviewed changes

sahar-fehri added the team-assets label May 12, 2026

sahar-fehri marked this pull request as ready for review May 12, 2026 01:15

sahar-fehri requested review from a team as code owners May 12, 2026 01:15

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread app/components/UI/Charts/AdvancedChart/useOHLCVRealtime.ts

sahar-fehri commented May 12, 2026

View reviewed changes

sahar-fehri mentioned this pull request May 12, 2026

chore: add OHLCVService for real-time candlestick WebSocket streaming MetaMask/core#8695

Merged

4 tasks

fix: add feature flag to gate WS logic

89f5283

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread app/components/UI/Charts/AdvancedChart/useOHLCVRealtime.ts

sahar-fehri added 3 commits May 12, 2026 13:35

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

7664973

fix: merge conflict

38cf74e

fix: fix handling subscription error

6754036

github-actions Bot added size-XL and removed size-L labels May 12, 2026

fix: fix

1d8190f

fix: immediate poll on error

f7d859f

cursor Bot reviewed May 14, 2026

View reviewed changes

Comment thread app/components/UI/Charts/AdvancedChart/useOHLCVRealtime.ts

sahar-fehri added 2 commits May 14, 2026 11:52

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

2ea0f35

fix: ut

fd4200d

Prithpal-Sooriya previously approved these changes May 14, 2026

View reviewed changes

bergarces mentioned this pull request May 14, 2026

Release/984.0.0 MetaMask/core#8813

Merged

4 tasks

bump core-backend

0e1c567

bergarces dismissed Prithpal-Sooriya’s stale review via 0e1c567 May 14, 2026 13:35

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

88ec55d

cursor Bot reviewed May 14, 2026

View reviewed changes

Comment thread app/components/UI/Charts/AdvancedChart/useOHLCVRealtime.test.ts

Prithpal-Sooriya approved these changes May 14, 2026

View reviewed changes

Merge branch 'main' into chore/ohlcv-ws-streaming-integration

fe6f560

bergarces approved these changes May 14, 2026

View reviewed changes

christopherferreira9 approved these changes May 14, 2026

View reviewed changes

sahar-fehri enabled auto-merge May 14, 2026 14:45

weitingsun approved these changes May 14, 2026

View reviewed changes

sahar-fehri added this pull request to the merge queue May 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026

Prithpal-Sooriya added this pull request to the merge queue May 14, 2026

Merged via the queue into main with commit 2d3cc40 May 14, 2026
204 of 209 checks passed

Prithpal-Sooriya deleted the chore/ohlcv-ws-streaming-integration branch May 14, 2026 18:06

github-actions Bot locked and limited conversation to collaborators May 14, 2026

metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: add ohlcv websocket streaming#29739

chore: add ohlcv websocket streaming#29739
Prithpal-Sooriya merged 26 commits into
mainfrom
chore/ohlcv-ws-streaming-integration

sahar-fehri commented May 5, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

socket-security Bot commented May 11, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented May 12, 2026 •

edited

Loading

Uh oh!

sahar-fehri May 12, 2026

Uh oh!

Uh oh!

sahar-fehri May 12, 2026

Uh oh!

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 14, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

sahar-fehri commented May 5, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual Test Plan

Prerequisites

Adding console.log statements to the mobile hook

Enabling core logs in the debugger

Group A — No Code Changes (Just Tap and Observe)

Scenario 1: Basic WebSocket Subscription

Scenario 2: Navigate Away (Unsubscribe + Grace Period)

Scenario 3: Rapid Navigation (Grace Period Cancel)

Scenario 4: Switch Between Tokens

Scenario 5: Rapid Time Range Switching

Scenario 6: App Background / Foreground

Scenario 7: Unsupported Token (No OHLCV Data)

Group B — Requires Changing DEV Constants in useOHLCVRealtime.ts

Scenario 8: WebSocket Disconnect → REST Polling Fallback

Code to add

How it works

Steps to test

Expected logs:

Group C — Requires Editing .cjs in node_modules

Scenario 10: Subscribe Failure / Error Recovery

Code to add

Steps to test

Expected — look for these key logs:

Log Reference

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

socket-security Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sahar-fehri May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sahar-fehri May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 14, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sahar-fehri commented May 5, 2026 •

edited by cursor Bot

Loading

Group B — Requires Changing DEV Constants in `useOHLCVRealtime.ts`

Group C — Requires Editing `.cjs` in node_modules

socket-security Bot commented May 11, 2026 •

edited

Loading

codecov-commenter commented May 12, 2026 •

edited

Loading