-
-
Notifications
You must be signed in to change notification settings - Fork 280
feat: implement quote status update logic #8462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GeorgeGkas
wants to merge
34
commits into
main
Choose a base branch
from
swaps-quotes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
1fe19d3
feat: new
GeorgeGkas 2efe9f3
fix: use correct request field
GeorgeGkas e5e0779
style: fix lint
GeorgeGkas 3afb9f7
style: formatting
GeorgeGkas 2489b21
fix: package
GeorgeGkas 27e2ff3
feat: extract logic to service
GeorgeGkas 17f4900
style: fix
GeorgeGkas bdcb4f8
style: fix
GeorgeGkas 66c1e98
feat: add persist mechanism and state management
GeorgeGkas 9768267
Merge branch 'main' into swaps-quotes
GeorgeGkas f26d2bc
style: fix
GeorgeGkas 0d03c32
style: fix
GeorgeGkas 3ae606e
fix: edge case
GeorgeGkas 8e03e75
Merge branch 'main' into swaps-quotes
GeorgeGkas 3481a8e
style: lint
GeorgeGkas 277d97a
feat: improve
GeorgeGkas 2e0b70f
refactor: naming
GeorgeGkas c9fd515
feat: use quoteId rather than requestId
GeorgeGkas 4921fd5
style: lint
GeorgeGkas 0d8c536
fix: startup retry logic
GeorgeGkas b51b91e
feat: add error handling
GeorgeGkas 0fb17cb
feat: add enable flag
GeorgeGkas a328d15
style: fix
GeorgeGkas 64acb94
test: update
GeorgeGkas 64ec113
style: format
GeorgeGkas de7f861
test: fix
GeorgeGkas 91bab64
test: add tests
GeorgeGkas e5a633a
style: fix
GeorgeGkas 4cdbf1d
chore: add changelog
GeorgeGkas 7732c30
Merge branch 'main' into swaps-quotes
GeorgeGkas 7c742a5
chore: update changelog
GeorgeGkas c04f7ef
chore: changelog
GeorgeGkas 2505ac0
fix: cursor bugbot review
GeorgeGkas c2e1b23
refactor: type
GeorgeGkas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
|
|
||
| - Add required `quoteId: string` to `QuoteResponseSchema`; quote responses without a `quoteId` will now fail validation ([#8462](https://github.com/MetaMask/core/pull/8462)) | ||
|
|
||
|
Comment on lines
+12
to
+13
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please mark this as a breaking change. Client e2e tests will need to be updated |
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/multichain-network-controller` from `^3.0.6` to `^3.1.0` ([#8665](https://github.com/MetaMask/core/pull/8665)) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.