[SS-96] Setup alternate logic path for upsert_v2#35923
Open
patrickwwbutler wants to merge 3 commits intoMaterializeInc:mainfrom
Open
[SS-96] Setup alternate logic path for upsert_v2#35923patrickwwbutler wants to merge 3 commits intoMaterializeInc:mainfrom
patrickwwbutler wants to merge 3 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up logic to potentially use the new prototype upsert implementation written by @DAlperin and loosely described here: https://www.notion.so/materialize/Upsert-V2-Much-Simpler-Boogaloo-31913f48d37b807fa88bdeafc27c02d9?source=copy_link
The plan is to run this alternate implementation in a shadow cluster that copies the work done in production on certain customer's upsert workloads so we can evaluate for correctness and collect performance metrics before fully switching over.