Remove six and enum deps#215
Open
malfet wants to merge 1 commit intoMaratyszcza:masterfrom
Open
Conversation
Python-2 (as well as Python-3.4) are well past their EOL And six is not actually used by NNPACK codebase
Maratyszcza
requested changes
Feb 14, 2023
| SET(CONFU_DEPENDENCIES_BINARY_DIR ${CMAKE_BINARY_DIR}/deps | ||
| CACHE PATH "Confu-style dependencies binary directory") | ||
|
|
||
| IF(NNPACK_BACKEND STREQUAL "x86-64") |
Maratyszcza
requested changes
Feb 14, 2023
Owner
Maratyszcza
left a comment
Maratyszcza
left a comment
There was a problem hiding this comment.
Exit with an error if Python < 3.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python-2 (as well as Python-3.4) are well past their EOL
And six is not actually used by NNPACK codebase