Changes for variable number of cylinders#3
Open
deHarro wants to merge 7 commits intoMakuna:masterfrom
Open
Conversation
Changes to search COM port routine: - Don't ignore single digit port names - Ask 5 times for connection Removed viewport 3 and 4, respectively. Now only 2 viewports (hard coded)
Inserted pseudo code which would make the display adapt to the number of cylinders known from the Arduino app, provided the Arduino app would transmit the defined number of cylinders to the windows app. I don't speak C#, so the implementation is up to you, Michael
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserted pseudo code which would make the display adapt to the number of cylinders known from the Arduino app, provided the Arduino app would transmit the defined number of cylinders to the windows app.
I don't speak C#, so the implementation is up to you, Michael
To work, additions have to be done to the Arduino app (trasmit variable numberOfCylinders.
Dito for the Windows app, which has to receive this variable and handle it in an appropriate manner for the (pseudo code) query I implemented.
Also updated readme.md to have links to the corresponding projects, vice versa
The changes to COM port search are ok.
I hope, I didn't mess up things too bad in your code :)
Harry