Skip to content

Make the account summary 24 hours min requirement check more robust by using 24 hours minus 5 mins. #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hhhezhang wants to merge 2 commits into
base: dev
Choose a base branch
from
+2 −5
Open

Make the account summary 24 hours min requirement check more robust by using 24 hours minus 5 mins. #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a099f
Make the account smmary 24 hours min requirement check more robust by…
hhhezhang Jul 3, 2025
746fc56
Remove process_pending_orders call in Alpaca broker since it is only …
hhhezhang Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lumibot/brokers/alpaca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,6 @@ def _await_market_to_close(self, timedelta=None, strategy=None):
The calling strategy; forwarded so pending orders can be processed
the same way BacktestingBroker does.
"""
# First, handle any orders waiting to be processed.
self.process_pending_orders(strategy=strategy)
Copy link
Copy Markdown
Member

@grzesir grzesir Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?


# Seconds until the bell rings
time_to_close = self.get_time_to_close()

Expand Down
4 changes: 2 additions & 2 deletions lumibot/strategies/_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,8 +1660,8 @@ def should_send_account_summary_to_discord(self):
else:
time_since_last_account_summary = None

# Check if it has been at least 24 hours since the last account summary
if self.last_account_summary_dt is None or time_since_last_account_summary.total_seconds() >= 86400: # 24 hours
# Check if it has been at least 24 hours - 5mins since the last account summary
if self.last_account_summary_dt is None or time_since_last_account_summary.total_seconds() >= (86400 - 300):

This comment was marked as resolved.

Sign in to view

# Set the last account summary datetime to now
self.last_account_summary_dt = now

Expand Down
Loading