Replace custom CLI parser with System.CommandLine 2.0.8#590
Merged
Conversation
The hand-rolled CmdLine parser under Classes/CommandLine/ (~460 LOC) has a //TODO from years ago suggesting replacement. Swap it for System.CommandLine 2.0.8 (stable since 2026-05-12). Surface preserved: - --config <file> / -c <file> (new canonical forms) - -config <file> accepted as a hidden alias for back-compat with existing shortcuts/scripts - Positional args still accept log files and session files (.lxj) Also fixes a latent bug: the original code checked configFile.Exists before cmdLine.Parse(args) was called, so the config-file-import block was effectively dead. The System.CommandLine port parses first, so -config FILE actually imports now. Also fixes an edge case in FileOperationService.AddMultiFileTab where .lxj session files passed alongside log files in MultiFile mode were treated as raw log lines. Sessions are now split out and dispatched to the session loader before the multi-file tab is created.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-rolled CmdLine parser under Classes/CommandLine/ (~460 LOC) has a //TODO from years ago suggesting replacement. Swap it for System.CommandLine 2.0.8 (stable since 2026-05-12).
Surface preserved:
Also fixes a latent bug: the original code checked configFile.Exists before cmdLine.Parse(args) was called, so the config-file-import block was effectively dead. The System.CommandLine port parses first, so -config FILE actually imports now.
Also fixes an edge case in FileOperationService.AddMultiFileTab where .lxj session files passed alongside log files in MultiFile mode were treated as raw log lines. Sessions are now split out and dispatched to the session loader before the multi-file tab is created.