Open
Conversation
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
2 times, most recently
from
6546cb1 to
a8dd4b9
Compare
1 task
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
from
a8dd4b9 to
5df577c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4132 +/- ##
==========================================
- Coverage 17.98% 15.57% -2.42%
==========================================
Files 108 74 -34
Lines 23420 16009 -7411
Branches 10337 7381 -2956
==========================================
- Hits 4212 2493 -1719
+ Misses 14224 12719 -1505
+ Partials 4984 797 -4187
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 83 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
10 tasks
This comment was marked as resolved.
This comment was marked as resolved.
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
from
5df577c to
18b1f57
Compare
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
from
18b1f57 to
e598ce8
Compare
Bundle ReportBundle size has no change ✅ |
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
2 times, most recently
from
16835b9 to
c44c2ba
Compare
ReenigneArcher
changed the title
21 tasks
Eliminates the conditional manual declarations for HSYNTHETICPOINTERDEVICE and the Create/Inject/DestroySyntheticPointerDevice APIs in src/platform/windows/input.cpp. These guarded declarations (for __MINGW32__ && SUNSHINE_PREBUILT_BOOST) caused header conflicts with system Boost/WinUser headers on MinGW/MSYS2; removing them defers to the platform/system headers instead.
Bump Boost source artifacts for flatpak packaging to the build-deps release v2026.221.143859. Updated the download URLs and SHA256 checksums for both x86_64 and aarch64 tarballs so the flatpak build uses the new prebuilt Boost artifacts.
Fetch build-deps tags for CI shallow clones; detect and prefer relocatable Boost package configs when available (find_package CONFIG) and fall back to creating manual imported Boost targets with proper include/libs and inter-target link properties. Add headers and log_setup components, expose Boost_INCLUDE_DIRS/Boost_LIBRARIES, and normalize Boost::boost/headers targets. Fix Windows compile definitions by removing ".lib" suffix from synchronization and add bcrypt to FFMPEG platform libraries (two locations) to ensure required Windows crypto dependency is linked.
Simplify cmake/prep/options.cmake by removing the APPLE-specific conditional and setting BOOST_USE_STATIC to ON unconditionally. Previously macOS defaulted to OFF; this change makes static Boost the default on all platforms.
Update cmake/dependencies/Boost_Sunshine.cmake to ensure Boost::locale links its required system libraries on UNIX. Initialize a _boost_locale_link_libraries list with Boost::headers, find and append Iconv and ICU (components: data, i18n, uc) on UNIX, and set Boost::locale's INTERFACE_LINK_LIBRARIES to that list instead of the previous hard-coded value. Unset the temporary variable afterward. This ensures locale has proper dependencies when using prepared Boost binaries on UNIX.
Remove dependency on boost::locale/ICU and replace runtime conversion with an internal UTF-8→UTF-32 decoder. Changes: - Implement utf8_to_utf32 in src/platform/linux/input/inputtino_keyboard.cpp and use it in unicode(), logging on decode failure instead of using boost::locale conversions. - Remove #include <boost/locale.hpp> from all inputtino_* headers and sources under src/platform/linux/input. - Update cmake/dependencies/Boost_Sunshine.cmake to drop Boost.Locale component and related ICU/Iconv linkage and remove Boost::locale from Boost_LIBRARIES and component lists. - Update packaging/sunshine.rb to remove static-boost options, boost and icu4c dependencies, and the static-boost configuration and add_boost_args usage. - Remove icu4c@78 from the macOS CI workflow (.github/workflows/ci-macos.yml). This reduces external ICU/Boost.Locale coupling and avoids requiring ICU for static Boost linking by using a lightweight built-in UTF-8 decoder for keyboard input handling.
Introduce a unified UTF utility module (src/platform/utf_utils.h/.cpp) implementing utf8_to_utf32 and platform helpers, and centralize UTF conversions for all platforms. Replace many local include paths to use the new header, remove the old platform/windows/utf_utils.h header, and update the Windows utf_utils implementation to use the new public header. Wire the new sources into CMake and tools (common and tools CMakeLists), add unit tests for utf8 decoding, and update linux keyboard input to call utf_utils::utf8_to_utf32 with additional input validation. This consolidates UTF handling and improves validation of UTF-8 inputs.
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
from
d9a9811 to
5cef857
Compare
ReenigneArcher
changed the title
ReenigneArcher
force-pushed
the
build/deps/use-pre-compiled-boost
branch
from
5cef857 to
cdec316
Compare
|
Member
Author
|
Cannot use boost locale as is, because it will opportunistically link against icu and iconv and expects the same version that was available when boost was compiled. See LizardByte/build-deps#654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will attempt to use the new boost pre-compiled libraries with a fallback to use CPM.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage