Fix ClassLoader leak caused by static ExecutorService in Async#2255
Open
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Open
Fix ClassLoader leak caused by static ExecutorService in Async#2255Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
Contributor
|
over all this is:
Also:
|
Dev10-sys
force-pushed
the
fix/async-executor-memory-leak
branch
4 times, most recently
from
1abc937 to
68a6e16
Compare
- Improve Async executor handling to prevent memory leaks in web containers. - Implement thread-safe lazy initialization of the executor. - Allow safe re-initialization of the executor after it has been shut down. - Add thread naming and daemon status to the shared thread pool for better visibility. - Include AsyncLifecycleTest to verify the fix. - Fixes LFDT-web3j#2244 Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Dev10-sys
force-pushed
the
fix/async-executor-memory-leak
branch
from
68a6e16 to
8315323
Compare
Contributor
Author
|
@gtebrean Thanks for feedback, that helped. Let me know if there’s anything else you’d like me to adjust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a manual shutdown method for the static ExecutorService used in Async.java.
Right now the executor is only shut down using a JVM shutdown hook. This works for
normal applications, but in web containers like Tomcat or Jetty the JVM does not stop
when a web application is reloaded or undeployed. Because of this, the executor threads
can stay alive and keep references to the old ClassLoader, which may cause memory leaks
over time.
This change adds a public static shutdown() method so the executor can be stopped
manually when the application is being shut down or undeployed.
The shutdown method safely:
This change does not modify existing behavior and is backward compatible.
Why is it needed?
In web container environments, applications can be reloaded without stopping the JVM.
In that case, the static executor may keep running and hold references to the old
ClassLoader, which can lead to ClassLoader memory leaks. Providing a manual shutdown
method allows proper cleanup.
Checklist
Fixes #2244