Skip to content

Support for Oled display driver SSD1363#7242

Open
tmolbergen wants to merge 7 commits intoKlipper3d:masterfrom
tmolbergen:master
Open

Support for Oled display driver SSD1363#7242
tmolbergen wants to merge 7 commits intoKlipper3d:masterfrom
tmolbergen:master

Conversation

@tmolbergen
Copy link
Copy Markdown

This PR has been created to add support for the oled display driver SSD1363

My rational for adding this support is i wanted a larger display voron v0 display and the SSD1309 display was indeed a bigger display, but the pixels got 'too chonky' for my taste.

as a disclaimer: AI was used to create this code and it was asked to copy the instructions used in this issue reference
olikraus/u8g2#2298

The instruction set in SSD1306 vs SSD1363 while similar were not a one to one mapping, due to the difference in protocol specification and the available instructions

as a note; I have intentionally left all of the AI comments, while they might be redundant for any seasoned developer, they do highlight alot of my thought process for getting this implementation done.

A couple of implementation notes for consideration and discussion if you want to merge this upstream;

  1. I added support for enlarged icons/text/glyphs in the home menu - The thought behind this was that the status menu should be easily read/observed from a distance, therefore the extra readability could go a long way.
  • Should this be made configurable for anyone wishing to not use the enlarged home menu?
  1. the menu system is currently in half of the size as the main menu - the thought here is that you are so close to the display that readability should not be of an issue.
  • Should this also be configurable to cater for people wanting big letters instead?
  1. due to the extra amount of extra pixels avaliable, i thought it would be nice to utilize the greyscale avaliable in the SSD1636 - the 'emboss' config mapping makes the letters look more '3d like'

For now this picture is how its currently looking;
homemenu-embossed
navigationmenu-embossed
homingmenu-embossed

homemenu-none
navigationmenu-none

See videoclip for navigation look and feel;
https://github.com/user-attachments/assets/500edab2-bcfb-4460-8c05-610639063705

@tmolbergen
Copy link
Copy Markdown
Author

Apologies for the whitespace errors, I will fix that as soon as possible. (First time to actually do a PR towards klipper, alot to learn :))

@JamesH1978
Copy link
Copy Markdown
Collaborator

You also need to sign it off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks
James

Signed-off-by: Tor Martin Ølberg <tmolberg@gmail.com>
Signed-off-by: Tor Martin Ølberg <tmolberg@gmail.com>
@tmolbergen
Copy link
Copy Markdown
Author

You also need to sign it off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks

James

Does all the commits need the signoff? I.e i need to rewrite history or is it good enough as is?

@JamesH1978
Copy link
Copy Markdown
Collaborator

as long as its in there somewhere it should be fine, most do it in the main comment for the PR, some do it on every commit

@github-actions
Copy link
Copy Markdown

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants