Support for Oled display driver SSD1363#7242
Support for Oled display driver SSD1363#7242tmolbergen wants to merge 7 commits intoKlipper3d:masterfrom
Conversation
|
Apologies for the whitespace errors, I will fix that as soon as possible. (First time to actually do a PR towards klipper, alot to learn :)) |
|
You also need to sign it off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
Signed-off-by: Tor Martin Ølberg <tmolberg@gmail.com>
Signed-off-by: Tor Martin Ølberg <tmolberg@gmail.com>
Does all the commits need the signoff? I.e i need to rewrite history or is it good enough as is? |
|
as long as its in there somewhere it should be fine, most do it in the main comment for the PR, some do it on every commit |
|
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
This PR has been created to add support for the oled display driver SSD1363
My rational for adding this support is i wanted a larger display voron v0 display and the SSD1309 display was indeed a bigger display, but the pixels got 'too chonky' for my taste.
as a disclaimer: AI was used to create this code and it was asked to copy the instructions used in this issue reference
olikraus/u8g2#2298
The instruction set in SSD1306 vs SSD1363 while similar were not a one to one mapping, due to the difference in protocol specification and the available instructions
as a note; I have intentionally left all of the AI comments, while they might be redundant for any seasoned developer, they do highlight alot of my thought process for getting this implementation done.
A couple of implementation notes for consideration and discussion if you want to merge this upstream;
For now this picture is how its currently looking;



See videoclip for navigation look and feel;
https://github.com/user-attachments/assets/500edab2-bcfb-4460-8c05-610639063705