fix(vscode): reverse and aggregate subsession costs in TaskHeader tooltip#8788
Closed
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Closed
fix(vscode): reverse and aggregate subsession costs in TaskHeader tooltip#8788kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
…ltip Show the most recent subsessions on top in the cost tooltip and aggregate older entries into a summary line when there are more than 8 child sessions, keeping the tooltip readable with many subagents. Fixes #8787
…havior Cover both the few-subagents case (all shown individually in reverse order) and the many-subagents case (older sessions aggregated into a summary line). This commit can be cherry-picked independently.
| const items = breakdown() | ||
| if (items.length <= 1) return <span>{language.t("context.usage.sessionCost")}</span> | ||
| const collapsed = collapseCostBreakdown(items, (n) => | ||
| language.t("context.usage.olderSessions", { count: String(n) }), |
Contributor
Author
There was a problem hiding this comment.
WARNING: The aggregation label does not handle singular counts
language.t() only interpolates the count value here, so when exactly one child session is collapsed the tooltip renders grammatically incorrect text like 1 older sessions. Other parts of this codebase already use explicit _one / _other keys for count-sensitive strings; this tooltip should use the same pattern so the new summary row is correct across locales.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (22 files)
Reviewed by gpt-5.4-2026-03-05 · 1,295,852 tokens |
Contributor
|
Superseded by #8822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8787