guard android/ios surfaces in terminator_DestroySurfaceKHR#1946
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 16341. |
|
CI Vulkan-Loader build # 3585 running. |
|
CI Vulkan-Loader build # 3585 passed. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Brings the destroy surface code in line with the create surface code.
Because this loader doesn't support Android (currently) the existence of android code is vestigial. But since it might in the future (no plans, just that it is in the realm of possibility), its good to keep around.
The IOS path using the MACOS_MVK platform guard is odd, but since the create surface code has the same guard, I would rather it be consistent anyhow. Plus, I suspect the guard is that way for a reason.
3 participants
an android or ios surface is the smaller VkIcdSurfaceAndroid/VkIcdSurfaceIOS and never gets a surface_index, yet terminator_DestroySurfaceKHR reads surface_index and create_info straight off it and then indexes every driver's surface_list with that garbage, so bail out for those two platforms up front like wsi_unwrap_icd_surface already does.