clamp re-queried counts in terminator_EnumeratePhysicalDeviceGroups#1942
Open
aizu-m wants to merge 1 commit into
Open
clamp re-queried counts in terminator_EnumeratePhysicalDeviceGroups#1942aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing the device-group terminator while chasing a stack-smash report:
local_phys_dev_groupsis sized tototal_count, which is summed in the first pass that asks each ICD for its group count. The fill pass then re-queries every ICD intocount_this_time(EnumeratePhysicalDeviceson the no-device-group path,EnumeratePhysicalDeviceGroupsotherwise, both with a NULL property pointer) and indexes the array by that value. The re-queried count is never bounded to the space left in the array.So a driver that reports more devices on the second query than it did on the first walks off the end of the stack array. Both fill branches re-query, so both can overrun. Same count-drift behaviour the *2KHR emulators already guard against, here on the two-pass group path.
Clamp
count_this_timeto the remaining reserved space (total_count - cur_icd_group_count) right after each re-query. No change for a well-behaved driver where the two passes agree; the existing device-group tests stay green.