check realloc result before zeroing grown bytes in loader_realloc#1940
Open
aizu-m wants to merge 1 commit into
Open
check realloc result before zeroing grown bytes in loader_realloc#1940aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 13055. |
|
CI Vulkan-Loader build # 3573 running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was tracing the generic-list growth paths and stopped on loader_realloc.
The callers all check the returned pointer for NULL, so only the zero-fill inside loader_realloc touches it early. Guarded the memset on pNewMem so the tail is only cleared when realloc actually returned the resized block. Behaviour is unchanged on success.