Skip to content

Cleanly shutdown the GC messages task#186

Open
JamesWrigley wants to merge 1 commit intomasterfrom
gc-tasks
Open

Cleanly shutdown the GC messages task#186
JamesWrigley wants to merge 1 commit intomasterfrom
gc-tasks

Conversation

@JamesWrigley
Copy link
Copy Markdown
Member

start_gc_msgs_task() previously launched a lingering task that could cause hangs when Julia is started with multiple threads.

I'm hoping it'll fix hangs like this, which show that the task is stuck at the condition lock: https://buildkite.com/julialang/julia-master/builds/56286/steps/canvas?sid=019d66f2-8543-41d2-af4b-c14a111fed86

Change ported from JuliaParallel/DistributedNext.jl#62. @DilumAluthge, I think we should bump the Distributed version in Julia after this.

@JamesWrigley JamesWrigley self-assigned this Apr 7, 2026
@JamesWrigley JamesWrigley added the bug Something isn't working label Apr 7, 2026
`start_gc_msgs_task()` previously launched a lingering task that could cause
hangs when Julia is started with multiple threads.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (1a25fc7) to head (986a664).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   79.47%   79.56%   +0.08%     
==========================================
  Files          10       10              
  Lines        1959     1967       +8     
==========================================
+ Hits         1557     1565       +8     
  Misses        402      402              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant