Skip to content

export sqs_messages function#6

Open
xiuliren wants to merge 3 commits intoJuliaCloud:masterfrom
xiuliren:master
Open

export sqs_messages function#6
xiuliren wants to merge 3 commits intoJuliaCloud:masterfrom
xiuliren:master

Conversation

@xiuliren
Copy link
Copy Markdown
Contributor

otherwise the example in README.md won't work.

@xiuliren
Copy link
Copy Markdown
Contributor Author

ping @samoconnor

@xiuliren
Copy link
Copy Markdown
Contributor Author

is this package deprecated? It seems that AWSSDK is preferred.

@xiuliren
Copy link
Copy Markdown
Contributor Author

xiuliren commented Feb 4, 2018

removed the export function, but add some missing packages to fix the test error.
could you take a look? @samoconnor

@samoconnor
Copy link
Copy Markdown
Contributor

Hi @jingpengw, sorry about the delayed response.
No, this package isn't deprecated, this is a hand-written interface that takes care of error handling, retries, etc. AWSSDK is auto-generated by a script and simply provides a thin wrapper for the raw HTTP web service.

See the AWSCore.jl doc:

The AWSSDK.jl package provides automatically generated low-level API wrappers for each operation in each Amazon Web Service.

The following high-level packages are also available: AWS S3, AWS SQS, AWS SNS, AWS IAM, AWS EC2, AWS Lambda, AWS SES and AWS SDB. These packages include operation specific result structure parsing, error handling, type convenience functions, iterators, etc.

Comment thread src/AWSSQS.jl

using AWSCore
using SymDict
using AWSSDK.SQS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWSSQS.jl does not need AWSSDK.jl
It calls AWSCore.Services.sqs, defined here: https://github.com/JuliaCloud/AWSCore.jl/blob/master/src/Services.jl#L1572

Comment thread src/AWSSQS.jl
using SymDict
using HTTP

using MbedTLS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for changing the order of HTTP and MbedTLS?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just the SymDict was needed. Otherwise it won't compile.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying the order of using SymDict was an issue? What was the error message?

Comment thread REQUIRE Outdated
Retry
MbedTLS
HTTP 0.5.4
HTTP
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the presence of the minimum versions in REQUIRE causing a problem for you?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, I did not know that this is minimum version. was thinking about required version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added back of the tags.

Comment thread src/AWSSQS.jl
sqs_send_message, sqs_send_message_batch, sqs_receive_message,
sqs_delete_message, sqs_flush, sqs_get_queue_attributes, sqs_count,
sqs_busy_count
sqs_busy_count, sqs_messages
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to export the iterator because it has no test cases and needs a bit more work to be user friendlily. At present, it doesn't behave nicely if there are no more messages.
Note: beb67ce

If you're using it and would like to write some test cases that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants