Skip to content

Add skill to add FUS metrics - #8142

Open
Nataliya Valtman (nav-nav) wants to merge 1 commit into
masterfrom
rr/valtman/add-fus-skill
Open

Nataliya Valtman (nav-nav) wants to merge 1 commit into
masterfrom
rr/valtman/add-fus-skill

Conversation

@nav-nav

Copy link
Copy Markdown
Contributor

Adding new fus metrics requires changes in both kotlin and IntelliJ repos. To make this easier, a new skill is introduced

@kotlin-safemerge

kotlin-safemerge Bot commented Sep 14, 2026

Copy link
Copy Markdown

Code Owners

RuleOwnersApproval
/​.​claude/​
kotlin
kotlin-analysis-api
kotlin-build-infrastructure

Egorand 🔒
PR commands for maintainers
CommandDescriptionParameters
/safe-mergeRebase-merges with automatic fixup commit squashing--fixup Autosquash fixup commits (on by default)
/safe-squash-mergeSquash-merges with optional commit title/body override--title Title of the squashed commit
--message Body of the squashed commit
/dry-runRuns the test pipeline with changes rebased on latest master--retry Retry the CI run on failure
/test-publicTriggers the public test suite without rebasing on latest master
/test-privateTriggers the private test suite without rebasing on latest master
/codeownersTriggers code owners check and comment update
/fixupSquashes fixup commits and force pushes the branch
/cancel-coordinatorCancels the merge coordinator currently running for this branch
/cherry-pickCherry-picks this pull request onto a target release branch--target Release version to cherry-pick onto

@kodee-bot

kodee-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

Hi! It looks like there are no references to any YT issues in the commit messages.
If the change is non-functional, feel free to ignore the comment :)
Otherwise, please add them as requested in the guideline.

@Egorand Egor Andreevich (Egorand) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the skill worked pretty well except for skipping a couple of steps for unknown reasons. Here are the changes it helped me make:

The total spent on adding these two events was 4.31 credits using Claude Sonnet 5.

/final

Comment on lines +761 to +762
the value actually leaves the IDE. This check cannot be automated — hand these
instructions to the user (or follow them yourself in a sandbox IDE):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the agent didn't hand me these instructions.

`kotlin.gradle.performance_v2.<EventName>=…` description in
`build/events/FUS.properties` ✓.

## Commit conventions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but the agent did not create a commit, I had to do it myself.


Note that reporting a value that violates the metric's anonymization policy
(e.g. a string outside its allowed list) is *not* silently dropped — it
surfaces as a FUS error, which the integration test below checks for.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add a note for the agent to not try to compile the project at this point, as it's unnecessary (or provide clear instructions on how to compile the project). Something along the lines of:

Do not try to compile the code or run tests at this point, as you'll be adding an integration test next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants