Amplitude and Data Reader Revisions#394
Open
mashephe wants to merge 5 commits into
Open
Conversation
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_sim^shepherd_at_revisions/tests/summary.txt Build log: /work/halld/pull_request_test/halld_sim^shepherd_at_revisions/make_shepherd_at_revisions.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few amplitudes with GPU classes that are being used for b1 fitting. It does not include changes to Vec_ps class because the branch being used in analysis has diverged from the master.
Significant performance enhancements were obtained by caching all relevant sines and cosines for DeltaAngles. This reduces the amplitude calculation down to basic floating point operations.
In other places I cleaned up printing to the screen to use AmpTools report class. This avoids a repeated messages when using MPI and allows the user to adjust the level of verbosity.