Ilbelov 3pi fits

[iljatt]

VecPs plotter is erased by mistake. Please, recover it.

A few amplitudes are added.
breakupmomentumComplex is a complex-valued function for breakupmomentum , which will return an imaginary value in case M < m1+m2.

[gluex]

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/make_ilbelov_3pi_fits.log
Build report: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/report_ilbelov_3pi_fits.txt
Location of build: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits

[gluex]

Test status for this pull request: FAILURE

Failures: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/failures.txt
Summary: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/log

Build log: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/make_ilbelov_3pi_fits.log
Build report: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/report_ilbelov_3pi_fits.txt
Location of build: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits

[aaust]

The latest failure does not seem to be caused by your code, as the compilation succeeded and only the test processes time out. I will investigate further.

[gluex]

Test status for this pull request: FAILURE

Failures: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/failures.txt
Summary: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/log

Build log: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/make_ilbelov_3pi_fits.log
Build report: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/report_ilbelov_3pi_fits.txt
Location of build: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits

[gluex]

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/tests/log

Build log: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/make_ilbelov_3pi_fits.log
Build report: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/report_ilbelov_3pi_fits.txt
Location of build: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits

[edbarriga]

Hi Ilia!
I still need to look over some large plots, but here are a set of initial comments:
Regarding the breakMomentumComplex files:

• I think the function can be added to the existing breakMomentum. This would make maintenance easier, unless there is a reason to keep both functions in separate files
• the breakMomentum has a GPU file breakupMometum.ch. Could you also update it with the new function?
  Regarding the BreitWigner file:
• The file is currently only using the existing breakupMomentum function. Was the idea to use the new complex function here?
  Regarding the SConscript file:
• It includes 'vec3pi_plotter', this plotter does not exist in the current master branch, nor do I see it in the files to be reviewed
  Lastly, for the Iso_ps_refl.cc file (which I still need to finish reviewing)
• line 198 uses barrier factors that use the breakup momentum. Would this be a place where the complex function would need to be used?

[iljatt]

1. 'vec3pi_plotter' should not be submitted --- it was added by mistake. Instead, I provide 'isops_plotter' plotter.
2. The breakupMomentumComplex function is called only by PiPiSWaveAMPK, but such a complex-valued function is not strictly necessary. It can be replaced with the existing breakupMomentum function with the double to complex type conversion taken into account (the lines 92,93).
3. On the other hand, such a complex-valued function can be added as a second function in breakupMomentum.cc

[edbarriga]

I'll be updating the files with the changes mentioned above. I will also remove other lines where the VecPs_3pi_refl is mentioned

[edbarriga]

Added the breakup momentum complex function to the old file and deleted VecPs_3pi_refl references

[edbarriga]

The breakup momentum complex function was combined with the old file in case someone needs it. The current code was changed to use the non-complex function. References to VecPs_3pi_refl were deleted

[gluex]

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/make_ilbelov_3pi_fits.log
Build report: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits/report_ilbelov_3pi_fits.txt
Location of build: /work/halld/pull_request_test/halld_sim^ilbelov_3pi_fits

[aaust]

Please do not merge untested branches to the repository.