This repository was archived by the owner on Apr 27, 2026. It is now read-only.
fix(notifications): hide action bar when all actions have empty IDs - #1181
Closed
shunkakinoki wants to merge 1 commit into
Closed
fix(notifications): hide action bar when all actions have empty IDs#1181shunkakinoki wants to merge 1 commit into
shunkakinoki wants to merge 1 commit into
Conversation
Owner
|
Hey @shunkakinoki , thanks for this PR and for the time you put into it. HyprPanel is being archived in the next couple of weeks in favor of Wayle (context: #1193). Closing this PR since there won't be any further HyprPanel releases. Your branch is unaffected, so anyone forking HyprPanel can pick this up. If this also applies to Wayle, a PR at https://github.com/wayle-rs/wayle would be very welcome. Thanks again! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some applications (e.g. Claude Code) send notifications with an empty action — an action where
idis an empty string"". TheNotificationCardguard checksget_actions().length, which is> 0for this empty action, so theActionscomponent gets rendered. But since there are no real buttons, the result is a blank pale bar visible at the bottom of the notification popup.Fix
Filter out actions with an empty
idbefore:Notification/index.tsx— soactionBoxstaysnulland the bar is never renderedmapinActions/index.tsx— defensive filter so the button list is also clean ifActionsis ever called directlyTesting
id): action bar is hidden