Exclude meshes without selected vertices from transforms and selection center in vertex/edge mode#3543
Open
nklbdev wants to merge 1 commit into
Conversation
nklbdev
force-pushed
the
selection_center_and_transformations_only_for_selected_mesh_parts
branch
from
May 18, 2026 08:48
4deb23d to
0624a93
Compare
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nklbdev
force-pushed
the
selection_center_and_transformations_only_for_selected_mesh_parts
branch
from
May 18, 2026 10:00
0624a93 to
54a64d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When two meshes are selected, but vertices/edges are only selected on one of them, the other mesh still participates in Move, Rotate, and Resize operations — either by moving its entire position (global space) or all of its vertices (local space). The selection center also includes the unselected mesh, shifting the transform gizmo to an incorrect pivot.
Fix: In
vertexandedgeselection modes, Mesh and SplineMesh elements with no selected vertices are now skipped during all transform operations. The same guard is applied consistently across six locations:moveElementsInSpacetransform.jsresizeOnAxistransform.jsonMove(resize_tool)edit_transform.jsrotateOnAxistransform.jsrotateSelectedtransform.jsgetSelectionCentertransform.js