Skip to content

Split plutus-tx-plugin-tests#7714

Open
zliu41 wants to merge 3 commits intomasterfrom
zliu41/split-plugin-tests
Open

Split plutus-tx-plugin-tests#7714
zliu41 wants to merge 3 commits intomasterfrom
zliu41/split-plugin-tests

Conversation

@zliu41
Copy link
Copy Markdown
Member

@zliu41 zliu41 commented Apr 10, 2026

This test suite is very big and takes a long time to run.

@zliu41 zliu41 requested a review from a team April 10, 2026 16:12
@zliu41 zliu41 added the No Changelog Required Add this to skip the Changelog Check label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Execution Budget Golden Diff

0c5f27d (master) vs 3a25f96

output

This comment will get updated when changes are made.

@Unisay
Copy link
Copy Markdown
Contributor

Unisay commented Apr 13, 2026

The new test suites assocmap-plugin-tests and list-plugin-tests contain golden tests, but nix/project.nix only sets --no-create for the original suite:

plutus-tx-plugin.components.tests.plutus-tx-plugin-tests.testFlags = [ "--no-create" ];
plutus-tx-plugin.components.tests.size.testFlags = [ "--no-create" ];

Should we add the same for the two new suites?

plutus-tx-plugin.components.tests.assocmap-plugin-tests.testFlags = [ "--no-create" ];
plutus-tx-plugin.components.tests.list-plugin-tests.testFlags = [ "--no-create" ];

Without this, if a golden file is accidentally missing, CI would silently create it instead of failing.


As a minor note: most of these test groups (List property tests, Map property tests, BuiltinList/Budget, DataList/Budget, Array, etc.) can already be run in isolation via --test-options='-p "group name"' without splitting into separate suites. The exception is AssocMap golden tests — their Tasty group is named Budget (via testNested "Budget" in AssocMap/Spec.hs), which collides with the main Budget group. If the test groups were given unique names (e.g. AssocMap/Budget), all of them could be filtered with -p. That said, separate suites do give the added benefit of Hydra-level parallelism and independent failure reporting.

@zliu41
Copy link
Copy Markdown
Member Author

zliu41 commented Apr 13, 2026

The new test suites assocmap-plugin-tests and list-plugin-tests contain golden tests, but nix/project.nix only sets --no-create for the original suite

Good catch. I've addressed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Required Add this to skip the Changelog Check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants