Fail PlutusV1-V3 translation for non-empty subTransactionsTxBody#5669
Draft
Lucsanszky wants to merge 16 commits intolehins/memoize-transaction-validationfrom
Draft
Fail PlutusV1-V3 translation for non-empty subTransactionsTxBody#5669Lucsanszky wants to merge 16 commits intolehins/memoize-transaction-validationfrom
subTransactionsTxBody#5669Lucsanszky wants to merge 16 commits intolehins/memoize-transaction-validationfrom
Conversation
Add `mkPlutusTxInfoFromResult` and `toPlutusTxInfoForPurpose` helpers to aid in using this nested complexity.
For now, this only adds a guard against non-empty `subTransactionsTxBodyL`
Lucsanszky
changed the base branch from
master
to
lehins/memoize-transaction-validation
Lucsanszky
changed the title
subTransactionsTxBody
Lucsanszky
commented
Mar 23, 2026
| unless (null (tx ^. bodyTxL . subTransactionsTxBodyL)) $ | ||
| Left $ | ||
| inject $ | ||
| SubTxIsNotSupported @era (txIdTx tx) |
Contributor
Author
There was a problem hiding this comment.
Is it appropriate to use this error here as well, or should we create a separate one? Also, is it okay to use the TopTx's ID as the TxId parameter? If not, then I guess we would like to pass in all the SubTx IDs that are present and modify SubTxIsNotSupported to take a set of Tx IDs (that is if we don't want to create a separate error for this).
Comment on lines
+398
to
+404
| guardDijkstraFeaturesForPlutusV1toV3 :: | ||
| forall era. | ||
| ( EraTx era | ||
| , DijkstraEraTxBody era | ||
| , Inject (DijkstraContextError era) (ContextError era) | ||
| ) => | ||
| Tx TopTx era -> |
Contributor
Author
There was a problem hiding this comment.
I thought we might want to create a guard function, just like in the Conway era for example. Let me know if that's not the case.
lehins
force-pushed
the
lehins/memoize-transaction-validation
branch
3 times, most recently
from
2a9eb1f to
438ac22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).