feat: file-mount-secret

.github/workflows/Build-Test-And-Deploy.yml

@@ -80,6 +80,14 @@ jobs:
           cache-dir: buildkit-cache
           skip-extraction: false
 
+      - name: Generate Docker NuGet credentials config
+        env:
+          NUGET_FEED_TOKEN: ${{ secrets.AZURE_DEVOPS_PAT }}
+        run: |
+          mkdir -p "${RUNNER_TEMP}/nuget"
+          bash scripts/nuget/emit-creds-config.sh > "${RUNNER_TEMP}/nuget/NuGet.Config"
+          chmod 600 "${RUNNER_TEMP}/nuget/NuGet.Config"
+
       # Only build for dev registry — prod gets the image via az acr import in deploy-production
       - name: Build Container Image
         if: github.event_name != 'pull_request_target' && github.event_name != 'pull_request'
@@ -88,12 +96,16 @@ jobs:
           tags: ${{ vars.DEVCONTAINER_REGISTRY }}/essentialcsharpweb:${{ github.sha }},${{ vars.DEVCONTAINER_REGISTRY }}/essentialcsharpweb:latest
           file: ./EssentialCSharp.Web/Dockerfile
           context: .
-          secrets: |
-            "nuget_pat=${{ secrets.AZURE_DEVOPS_PAT }}"
+          secret-files: |
+            "nuget_config=${{ runner.temp }}/nuget/NuGet.Config"
           outputs: type=docker,dest=${{ github.workspace }}/essentialcsharpwebimage.tar
           cache-from: type=gha,scope=essentialcsharpweb-main
           cache-to: type=gha,mode=max,scope=essentialcsharpweb-main
 
+      - name: Remove Docker NuGet credentials config
+        if: always()
+        run: rm -f "${RUNNER_TEMP}/nuget/NuGet.Config"
+
       - name: Upload artifact
         uses: actions/upload-artifact@v7
         with:
@@ -321,4 +333,3 @@ jobs:
             az logout
             az cache purge
             az account clear
-

EssentialCSharp.Web/Dockerfile

@@ -26,18 +26,13 @@ COPY EssentialCSharp.Chat.Tests/EssentialCSharp.Chat.Tests.csproj ./EssentialCSh
 COPY EssentialCSharp.Chat/EssentialCSharp.Chat.csproj ./EssentialCSharp.Chat/
 COPY EssentialCSharp.Web.Tests/EssentialCSharp.Web.Tests.csproj ./EssentialCSharp.Web.Tests/
 COPY EssentialCSharp.Web/EssentialCSharp.Web.csproj ./EssentialCSharp.Web/
-RUN --mount=type=secret,id=nuget_pat,required=false \
+RUN mkdir -p /root/.nuget/NuGet
+RUN --mount=type=secret,id=nuget_config,required=false,target=/root/.nuget/NuGet/NuGet.Config \
     --mount=type=cache,id=essentialcsharp-web-nuget,target=/root/.nuget/packages \
-    if [ "$ACCESS_TO_NUGET_FEED" = "true" ] && [ ! -s /run/secrets/nuget_pat ]; then \
-      echo "ERROR: ACCESS_TO_NUGET_FEED=true but nuget_pat secret is missing or empty" >&2; exit 1; \
+    if [ "$ACCESS_TO_NUGET_FEED" = "true" ] && [ ! -s /root/.nuget/NuGet/NuGet.Config ]; then \
+      echo "ERROR: ACCESS_TO_NUGET_FEED=true but nuget_config secret is missing or empty" >&2; exit 1; \
     fi && \
-    if [ "$ACCESS_TO_NUGET_FEED" = "true" ]; then \
-      mkdir -p /root/.nuget/NuGet && \
-      printf '<?xml version="1.0" encoding="utf-8"?>\n<configuration>\n  <packageSourceCredentials>\n    <EssentialCSharp>\n      <add key="Username" value="az" />\n      <add key="ClearTextPassword" value="%s" />\n    </EssentialCSharp>\n  </packageSourceCredentials>\n</configuration>\n' \
-        "$(cat /run/secrets/nuget_pat)" > /root/.nuget/NuGet/NuGet.Config; \
-    fi && \
-    dotnet restore "EssentialCSharp.Web.slnx" -p:AccessToNugetFeed=$ACCESS_TO_NUGET_FEED && \
-    rm -f /root/.nuget/NuGet/NuGet.Config
+    dotnet restore "EssentialCSharp.Web.slnx" -p:AccessToNugetFeed=$ACCESS_TO_NUGET_FEED
 COPY . .
 COPY --from=frontend-build /frontend/EssentialCSharp.Web/wwwroot/dist ./EssentialCSharp.Web/wwwroot/dist
 RUN --mount=type=cache,id=essentialcsharp-web-nuget,target=/root/.nuget/packages \

scripts/nuget/emit-creds-config.sh

@@ -0,0 +1,43 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/nuget/feed.sh
+source "${script_dir}/feed.sh"
+
+token="${1:-${NUGET_FEED_TOKEN:-}}"
+username="${2:-${FEED_USERNAME}}"
+
+if [[ -z "${token}" ]]; then
+  echo "emit-creds-config.sh: no token (pass as \$1 or set NUGET_FEED_TOKEN)" >&2
+  exit 1
+fi
+
+xml_escape() {
+  local value="${1}"
+  value="${value//&/&}"
+  value="${value//</&lt;}"
+  value="${value//>/&gt;}"
+  value="${value//\"/&quot;}"
+  printf '%s' "${value}"
+}
+
+if [[ ! "${FEED_NAME}" =~ ^[A-Za-z_][A-Za-z0-9._-]*$ ]]; then
+  echo "emit-creds-config.sh: FEED_NAME must be a valid NuGet.Config XML element name" >&2
+  exit 1
+fi
+
+escaped_username="$(xml_escape "${username}")"
+escaped_token="$(xml_escape "${token}")"
+
+cat <<EOF
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <packageSourceCredentials>
+    <${FEED_NAME}>
+      <add key="Username" value="${escaped_username}" />
+      <add key="ClearTextPassword" value="${escaped_token}" />
+    </${FEED_NAME}>
+  </packageSourceCredentials>
+</configuration>
+EOF

scripts/nuget/feed.sh

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+
+FEED_NAME="${FEED_NAME:-EssentialCSharp}"
+FEED_USERNAME="${FEED_USERNAME:-az}"