Remove algorithm identification from background class#413
Open
CPBridge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highdicom automatically populates details of the background segment description when a LABELMAP segmentation is created. This currently includes the segmentation algorithm identification sequence, which is copied from the first segment the user passes. However, this information is not required by the standard (only by the highdicom implementation of SegmentDescription as an opinionated decision), so we are free to remove this information from the background segment description.
Since it's not really clear how to decide which algorithm if any "created" the background class, this PR removes the algorithm identification information from the background segment.