refactor(igc-ts): cleanup project scripts setup#1622
Open
damyanpetev wants to merge 10 commits intomasterfrom
Open
refactor(igc-ts): cleanup project scripts setup#1622damyanpetev wants to merge 10 commits intomasterfrom
damyanpetev wants to merge 10 commits intomasterfrom
Conversation
|
coverage: 86.278%. remained the same — dpetev/update-wc into master |
…t glob (#1643) Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/51e04015-4baf-40fc-9eed-0b8c51a6c114 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the igc-ts Web Components project templates to simplify the tooling setup (Vite-first workflow), modernize TypeScript/lint configuration, and align template code with the updated build/dev story.
Changes:
- Update Web Components template entrypoints to load
./src/index.ts(instead of./dist/src/index.js) and adjust corresponding update spec expectations. - Simplify template
package.jsonscripts/dependencies (removetsc/concurrently/rimrafpipeline; usevite/vitestdirectly; movetypescripttodevDependencies). - Modernize template TS/ESLint config (bundler-mode
tsconfig, lit ESLint flat config, and a narrowerparserOptions.projectlist in repo ESLint config).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/unit/update-spec.ts | Updates the HTML fixture expectations used by workspace update unit tests to match the new template entrypoint. |
| packages/cli/templates/webcomponents/igc-ts/projects/side-nav/files/src/app/app.ts | Layout/style adjustments for side-nav template + minor template cleanup. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/src/app/app-routing.ts | Uses import { type Route } for type-only import. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/package.json | Simplifies scripts and dependency placement for the “base with home” template. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/index.html | Switches entry script to ./src/index.ts. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/vite.config.ts | Minor config cleanup (including removing emptyOutDir: false). |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/tsconfig.test.json | Removes the dedicated test TS config (no longer referenced by scripts). |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/tsconfig.json | Replaces old emit-based TS config with Vite-style “bundler mode” no-emit config. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/src/app/app-routing.ts | Uses import { type Route } for type-only import. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/package.json | Simplifies scripts and dependency placement for the base template. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/index.html | Switches entry script to ./src/index.ts. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.js | Adds lit flat recommended config + normalizes formatting. |
| packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/path/filePrefix.ts | Converts a type import to type-only import. |
| packages/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/path/filePrefix.ts | Converts a type import to type-only import. |
| packages/cli/templates/webcomponents/igc-ts/dock-manager/default/files/src/app/path/filePrefix.ts | Converts a type import to type-only import. |
| packages/cli/templates/webcomponents/igc-ts/card/default/files/src/app/path/filePrefix.ts | Updates component registrations and card actions markup for the card template. |
| eslint.config.mjs | Narrows TypeScript project references used by ESLint’s TS parser. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # .
Additional information related to this pull request: